From: Hans de Goede <hdegoede@redhat.com>
To: W_Armin@gmx.de
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 0/2] hwmon: (sch5627) Replace hwmon_device_register()
Date: Tue, 13 Apr 2021 10:11:51 +0200 [thread overview]
Message-ID: <f9fc2b35-c634-97d3-54d0-0048586f4abc@redhat.com> (raw)
In-Reply-To: <20210411164225.11967-1-W_Armin@gmx.de>
Hi,
On 4/11/21 6:42 PM, W_Armin@gmx.de wrote:
> From: Armin Wolf <W_Armin@gmx.de>
>
> When the sch5627 driver is loaded, a warning is displayed during
> bootup about hwmon_device_register() being deprecated.
>
> The first patch solves that issue, and the second patch adds
> a minor optimization when reading sensor data.
>
> Both patches have been tested on a Fujitsu Esprimo P720
> and appear to work without issues.
Thank you for doing this, both patches look good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
For both patches.
Regards,
Hans
> Armin Wolf (2):
> hwmon: (sch5627) Convert to hwmon_device_register_with_info()
> hwmon: (sch5627) Split sch5627_update_device()
>
> drivers/hwmon/sch5627.c | 445 ++++++++++++++++------------------------
> 1 file changed, 180 insertions(+), 265 deletions(-)
>
> --
> 2.20.1
>
prev parent reply other threads:[~2021-04-13 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 16:42 [PATCH 0/2] hwmon: (sch5627) Replace hwmon_device_register() W_Armin
2021-04-11 16:42 ` [PATCH 1/2] hwmon: (sch5627) Convert to hwmon_device_register_with_info() W_Armin
2021-04-11 16:42 ` [PATCH 2/2] hwmon: (sch5627) Split sch5627_update_device() W_Armin
2021-04-13 16:39 ` Guenter Roeck
2021-04-13 8:11 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9fc2b35-c634-97d3-54d0-0048586f4abc@redhat.com \
--to=hdegoede@redhat.com \
--cc=W_Armin@gmx.de \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).