From: Jiri Kosina <jikos@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Marius Zachmann <mail@mariuszachmann.de>,
Jean Delvare <jdelvare@suse.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v7] hwmon: add Corsair Commander Pro driver
Date: Tue, 7 Jul 2020 12:20:46 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2007071220210.15962@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200630021642.GA155878@roeck-us.net>
On Mon, 29 Jun 2020, Guenter Roeck wrote:
> On Fri, Jun 26, 2020 at 07:59:36AM +0200, Marius Zachmann wrote:
> > This is v7 of a driver for the Corsair Commander Pro.
> > It provides sysfs attributes for:
> > - Reading fan speed
> > - Reading temp sensors
> > - Reading voltage values
> > - Writing pwm and reading last written pwm
> > - Reading fan and temp connection status
> >
> > It is an usb driver, so it needs to be ignored by usbhid.
> > The Corsair Commander Pro is a fan controller and provides
> > no means for user interaction.
> > The two device numbers are there, because there is a slightly
> > different version of the same device. (Only difference
> > seem to be in some presets.)
> >
> > This is based on the staging/hwmon tree.
> >
> > Signed-off-by: Marius Zachmann <mail@mariuszachmann.de>
>
> For my reference:
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Waiting for Ack from HID maintainer.
Acked-by: Jiri Kosina <jkosina@suse.cz>
for the drivers/hid/hid-quirks.c hunk. Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-07-07 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 5:59 [PATCH v7] hwmon: add Corsair Commander Pro driver Marius Zachmann
2020-06-30 2:16 ` Guenter Roeck
2020-07-07 10:20 ` Jiri Kosina [this message]
2020-07-07 12:41 ` Benjamin Tissoires
2020-07-07 14:18 ` Guenter Roeck
2020-06-26 13:21 Guenter Roeck
2020-06-26 13:36 ` Marius Zachmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2007071220210.15962@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mail@mariuszachmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).