linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Wilczynski <kswilczynski@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Krzysztof Wilczynski <kw@linux.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Sasha Levin <sashal@kernel.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hyperv@vger.kernel.org
Subject: Re: [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c
Date: Thu, 29 Aug 2019 01:33:49 +0200	[thread overview]
Message-ID: <1567035229.11524.0@gmail.com> (raw)
In-Reply-To: <20190828222618.GE7013@google.com>

Hello Bjorn,
Thank you for feedback.

[...]
> Maybe just:
> 
>   PCI: hv: Make functions static
> 
> since we already know it's in pci-hyperv.c, and it's obvious that you
> can only do this for functions that are only used locally.

Makes sense.  I will update the subject line in v3.

[...]
> Rewrap commit log to fill 75 columns.

Sorry about this.  I wasn't sure if one also should wrap compiler and/or
checkpatch.pl script warnings or errors.  I will fix this.

> Does this fix all the similar warnings in drivers/pci/?  If there are
> more, maybe we could fix them all in a single patch or at least a
> single series?

At the moment, while compiling the drivers/pci the compiler yields a 
similar
warning for the following files:

arch/x86/pci/xen.c
arch/x86/pci/numachip.c
drivers/pci/controller/pci-hyperv.c
drivers/pci/vc.c

I will have a look at each closer.

Krzysztof



      reply	other threads:[~2019-08-28 23:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 15:41 [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Krzysztof Wilczynski
2019-08-28 22:18 ` [PATCH v2] " Krzysztof Wilczynski
2019-08-28 22:32   ` Haiyang Zhang
2019-08-29  0:08     ` Krzysztof Wilczynski
2019-08-29  9:17   ` [PATCH v3] PCI: hv: Make functions static Krzysztof Wilczynski
2019-08-29 15:50     ` Haiyang Zhang
2019-09-04 14:27       ` Lorenzo Pieralisi
2019-09-04 14:36         ` Krzysztof Wilczynski
2019-08-28 22:26 ` [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Bjorn Helgaas
2019-08-28 23:33   ` Krzysztof Wilczynski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1567035229.11524.0@gmail.com \
    --to=kswilczynski@gmail.com \
    --cc=haiyangz@microsoft.com \
    --cc=helgaas@kernel.org \
    --cc=kw@linux.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=sashal@kernel.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).