linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: decui@microsoft.com
Cc: jhansen@vmware.com, stefanha@redhat.com, sgarzare@redhat.com,
	netdev@vger.kernel.org, sthemmin@microsoft.com,
	Alexander.Levin@microsoft.com, sashal@kernel.org,
	haiyangz@microsoft.com, kys@microsoft.com,
	mikelley@microsoft.com, linux-hyperv@vger.kernel.org,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vsock: Fix a lockdep warning in __vsock_release()
Date: Tue, 20 Aug 2019 12:45:49 -0700 (PDT)	[thread overview]
Message-ID: <20190820.124549.2048964358332749388.davem@davemloft.net> (raw)
In-Reply-To: <1566270830-28981-1-git-send-email-decui@microsoft.com>

From: Dexuan Cui <decui@microsoft.com>
Date: Tue, 20 Aug 2019 03:14:22 +0000

> +static void __vsock_release2(struct sock *sk)

Do not duplicate an entire function just to adjust some aspect of the
lock debugging, please find a cleaner and more minimal way to
implement this fix.

  reply	other threads:[~2019-08-20 19:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  3:14 [PATCH] vsock: Fix a lockdep warning in __vsock_release() Dexuan Cui
2019-08-20 19:45 ` David Miller [this message]
2019-08-22 10:25 ` Stefano Garzarella
2019-09-26  1:10   ` Dexuan Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820.124549.2048964358332749388.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Alexander.Levin@microsoft.com \
    --cc=decui@microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=jhansen@vmware.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).