* [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c @ 2019-08-26 15:41 Krzysztof Wilczynski 2019-08-28 22:18 ` [PATCH v2] " Krzysztof Wilczynski 2019-08-28 22:26 ` [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Bjorn Helgaas 0 siblings, 2 replies; 10+ messages in thread From: Krzysztof Wilczynski @ 2019-08-26 15:41 UTC (permalink / raw) To: Bjorn Helgaas Cc: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Sasha Levin, Lorenzo Pieralisi, linux-pci, linux-kernel, linux-hyperv Functions hv_read_config_block(), hv_write_config_block() and hv_register_block_invalidate() are not used anywhere else and are local to drivers/pci/controller/pci-hyperv.c, and do not need to be in global scope, so make these static. Resolve compiler warning that can be seen when building with warnings enabled (W=1). Signed-off-by: Krzysztof Wilczynski <kw@linux.com> --- drivers/pci/controller/pci-hyperv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index f1f300218fab..c9642e429c2d 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -930,7 +930,7 @@ static void hv_pci_read_config_compl(void *context, struct pci_response *resp, * * Return: 0 on success, -errno on failure */ -int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, +static int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, unsigned int block_id, unsigned int *bytes_returned) { struct hv_pcibus_device *hbus = @@ -1010,7 +1010,7 @@ static void hv_pci_write_config_compl(void *context, struct pci_response *resp, * * Return: 0 on success, -errno on failure */ -int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, +static int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, unsigned int block_id) { struct hv_pcibus_device *hbus = @@ -1079,7 +1079,7 @@ int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, * * Return: 0 on success, -errno on failure */ -int hv_register_block_invalidate(struct pci_dev *pdev, void *context, +static int hv_register_block_invalidate(struct pci_dev *pdev, void *context, void (*block_invalidate)(void *context, u64 block_mask)) { -- 2.22.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] PCI: hv: Make functions only used locally static in pci-hyperv.c 2019-08-26 15:41 [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Krzysztof Wilczynski @ 2019-08-28 22:18 ` Krzysztof Wilczynski 2019-08-28 22:32 ` Haiyang Zhang 2019-08-29 9:17 ` [PATCH v3] PCI: hv: Make functions static Krzysztof Wilczynski 2019-08-28 22:26 ` [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Bjorn Helgaas 1 sibling, 2 replies; 10+ messages in thread From: Krzysztof Wilczynski @ 2019-08-28 22:18 UTC (permalink / raw) To: Bjorn Helgaas Cc: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Sasha Levin, Lorenzo Pieralisi, linux-pci, linux-kernel, linux-hyperv Functions hv_read_config_block(), hv_write_config_block() and hv_register_block_invalidate() are not used anywhere else and are local to drivers/pci/controller/pci-hyperv.c, and do not need to be in global scope, so make these static. Resolve following compiler warning that can be seen when building with warnings enabled (W=1): drivers/pci/controller/pci-hyperv.c:933:5: warning: no previous prototype for ‘hv_read_config_block’ [-Wmissing-prototypes] int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, ^ drivers/pci/controller/pci-hyperv.c:1013:5: warning: no previous prototype for ‘hv_write_config_block’ [-Wmissing-prototypes] int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, ^ drivers/pci/controller/pci-hyperv.c:1082:5: warning: no previous prototype for ‘hv_register_block_invalidate’ [-Wmissing-prototypes] int hv_register_block_invalidate(struct pci_dev *pdev, void *context, ^ Signed-off-by: Krzysztof Wilczynski <kw@linux.com> --- Changes in v2: Update commit message to include compiler warning. drivers/pci/controller/pci-hyperv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index f1f300218fab..c9642e429c2d 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -930,7 +930,7 @@ static void hv_pci_read_config_compl(void *context, struct pci_response *resp, * * Return: 0 on success, -errno on failure */ -int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, +static int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, unsigned int block_id, unsigned int *bytes_returned) { struct hv_pcibus_device *hbus = @@ -1010,7 +1010,7 @@ static void hv_pci_write_config_compl(void *context, struct pci_response *resp, * * Return: 0 on success, -errno on failure */ -int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, +static int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, unsigned int block_id) { struct hv_pcibus_device *hbus = @@ -1079,7 +1079,7 @@ int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, * * Return: 0 on success, -errno on failure */ -int hv_register_block_invalidate(struct pci_dev *pdev, void *context, +static int hv_register_block_invalidate(struct pci_dev *pdev, void *context, void (*block_invalidate)(void *context, u64 block_mask)) { -- 2.22.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH v2] PCI: hv: Make functions only used locally static in pci-hyperv.c 2019-08-28 22:18 ` [PATCH v2] " Krzysztof Wilczynski @ 2019-08-28 22:32 ` Haiyang Zhang 2019-08-29 0:08 ` Krzysztof Wilczynski 2019-08-29 9:17 ` [PATCH v3] PCI: hv: Make functions static Krzysztof Wilczynski 1 sibling, 1 reply; 10+ messages in thread From: Haiyang Zhang @ 2019-08-28 22:32 UTC (permalink / raw) To: Krzysztof Wilczynski, Bjorn Helgaas Cc: KY Srinivasan, Stephen Hemminger, Sasha Levin, Lorenzo Pieralisi, linux-pci, linux-kernel, linux-hyperv > -----Original Message----- > From: Krzysztof Wilczynski <kswilczynski@gmail.com> On Behalf Of Krzysztof > Wilczynski > Sent: Wednesday, August 28, 2019 3:19 PM > To: Bjorn Helgaas <helgaas@kernel.org> > Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang > <haiyangz@microsoft.com>; Stephen Hemminger > <sthemmin@microsoft.com>; Sasha Levin <sashal@kernel.org>; Lorenzo > Pieralisi <lorenzo.pieralisi@arm.com>; linux-pci@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-hyperv@vger.kernel.org > Subject: [PATCH v2] PCI: hv: Make functions only used locally static in pci- > hyperv.c > > Functions hv_read_config_block(), hv_write_config_block() > and hv_register_block_invalidate() are not used anywhere > else and are local to drivers/pci/controller/pci-hyperv.c, > and do not need to be in global scope, so make these static. > > Resolve following compiler warning that can be seen when > building with warnings enabled (W=1): > > drivers/pci/controller/pci-hyperv.c:933:5: warning: no previous prototype for > ‘hv_read_config_block’ [-Wmissing-prototypes] > int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > ^ > drivers/pci/controller/pci-hyperv.c:1013:5: warning: no previous prototype > for ‘hv_write_config_block’ [-Wmissing-prototypes] > int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > ^ > drivers/pci/controller/pci-hyperv.c:1082:5: warning: no previous prototype > for ‘hv_register_block_invalidate’ [-Wmissing-prototypes] > int hv_register_block_invalidate(struct pci_dev *pdev, void *context, > ^ > Signed-off-by: Krzysztof Wilczynski <kw@linux.com> > --- > Changes in v2: > Update commit message to include compiler warning. > > drivers/pci/controller/pci-hyperv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci- > hyperv.c > index f1f300218fab..c9642e429c2d 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -930,7 +930,7 @@ static void hv_pci_read_config_compl(void *context, > struct pci_response *resp, > * > * Return: 0 on success, -errno on failure > */ > -int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > +static int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > unsigned int block_id, unsigned int *bytes_returned) The second line should be aligned next to the "(" on the first line. Also the first line is now over 80 chars. Thanks, - Haiyang ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v2] PCI: hv: Make functions only used locally static in pci-hyperv.c 2019-08-28 22:32 ` Haiyang Zhang @ 2019-08-29 0:08 ` Krzysztof Wilczynski 0 siblings, 0 replies; 10+ messages in thread From: Krzysztof Wilczynski @ 2019-08-29 0:08 UTC (permalink / raw) To: Haiyang Zhang Cc: Krzysztof Wilczynski, Bjorn Helgaas, KY Srinivasan, Stephen Hemminger, Sasha Levin, Lorenzo Pieralisi, linux-pci, linux-kernel, linux-hyperv Hello Haiyang, Thank you for feedback. [...] > The second line should be aligned next to the "(" on the first line. > Also the first line is now over 80 chars. Sorry about this. I will fix it in v3. Thank you for pointing this out. To address both the alignment and line length of hv_register_block_invalidate(), I took a hint from the way how hv_compose_msi_req_v1() is current formatted. I hope that this would be acceptable. Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] PCI: hv: Make functions static 2019-08-28 22:18 ` [PATCH v2] " Krzysztof Wilczynski 2019-08-28 22:32 ` Haiyang Zhang @ 2019-08-29 9:17 ` Krzysztof Wilczynski 2019-08-29 15:50 ` Haiyang Zhang 1 sibling, 1 reply; 10+ messages in thread From: Krzysztof Wilczynski @ 2019-08-29 9:17 UTC (permalink / raw) To: Bjorn Helgaas Cc: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Sasha Levin, Lorenzo Pieralisi, linux-pci, linux-kernel, linux-hyperv Functions hv_read_config_block(), hv_write_config_block() and hv_register_block_invalidate() are not used anywhere else and are local to drivers/pci/controller/pci-hyperv.c, and do not need to be in global scope, so make these static. Resolve following compiler warning that can be seen when building with warnings enabled (W=1): drivers/pci/controller/pci-hyperv.c:933:5: warning: no previous prototype for ‘hv_read_config_block’ [-Wmissing-prototypes] drivers/pci/controller/pci-hyperv.c:1013:5: warning: no previous prototype for ‘hv_write_config_block’ [-Wmissing-prototypes] drivers/pci/controller/pci-hyperv.c:1082:5: warning: no previous prototype for ‘hv_register_block_invalidate’ [-Wmissing-prototypes] Signed-off-by: Krzysztof Wilczynski <kw@linux.com> --- Changes in v3: Commit message has been wrapped to fit 75 columns. Addressed formatting based on feedback from v2. Changes in v2: Update commit message to include compiler warning. drivers/pci/controller/pci-hyperv.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index f1f300218fab..ba988fe033b5 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -930,8 +930,9 @@ static void hv_pci_read_config_compl(void *context, struct pci_response *resp, * * Return: 0 on success, -errno on failure */ -int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, - unsigned int block_id, unsigned int *bytes_returned) +static int hv_read_config_block(struct pci_dev *pdev, void *buf, + unsigned int len, unsigned int block_id, + unsigned int *bytes_returned) { struct hv_pcibus_device *hbus = container_of(pdev->bus->sysdata, struct hv_pcibus_device, @@ -1010,8 +1011,8 @@ static void hv_pci_write_config_compl(void *context, struct pci_response *resp, * * Return: 0 on success, -errno on failure */ -int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, - unsigned int block_id) +static int hv_write_config_block(struct pci_dev *pdev, void *buf, + unsigned int len, unsigned int block_id) { struct hv_pcibus_device *hbus = container_of(pdev->bus->sysdata, struct hv_pcibus_device, @@ -1079,9 +1080,9 @@ int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, * * Return: 0 on success, -errno on failure */ -int hv_register_block_invalidate(struct pci_dev *pdev, void *context, - void (*block_invalidate)(void *context, - u64 block_mask)) +static int hv_register_block_invalidate( + struct pci_dev *pdev, void *context, + void (*block_invalidate)(void *context, u64 block_mask)) { struct hv_pcibus_device *hbus = container_of(pdev->bus->sysdata, struct hv_pcibus_device, @@ -1097,7 +1098,6 @@ int hv_register_block_invalidate(struct pci_dev *pdev, void *context, put_pcichild(hpdev); return 0; - } /* Interrupt management hooks */ -- 2.22.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH v3] PCI: hv: Make functions static 2019-08-29 9:17 ` [PATCH v3] PCI: hv: Make functions static Krzysztof Wilczynski @ 2019-08-29 15:50 ` Haiyang Zhang 2019-09-04 14:27 ` Lorenzo Pieralisi 0 siblings, 1 reply; 10+ messages in thread From: Haiyang Zhang @ 2019-08-29 15:50 UTC (permalink / raw) To: Krzysztof Wilczynski, Bjorn Helgaas Cc: KY Srinivasan, Stephen Hemminger, Sasha Levin, Lorenzo Pieralisi, linux-pci, linux-kernel, linux-hyperv > -----Original Message----- > From: Krzysztof Wilczynski <kswilczynski@gmail.com> On Behalf Of Krzysztof > Wilczynski > Sent: Thursday, August 29, 2019 2:17 AM > To: Bjorn Helgaas <helgaas@kernel.org> > Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang > <haiyangz@microsoft.com>; Stephen Hemminger > <sthemmin@microsoft.com>; Sasha Levin <sashal@kernel.org>; Lorenzo > Pieralisi <lorenzo.pieralisi@arm.com>; linux-pci@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-hyperv@vger.kernel.org > Subject: [PATCH v3] PCI: hv: Make functions static > > Functions hv_read_config_block(), hv_write_config_block() and > hv_register_block_invalidate() are not used anywhere else and are local to > drivers/pci/controller/pci-hyperv.c, > and do not need to be in global scope, so make these static. > > Resolve following compiler warning that can be seen when building with > warnings enabled (W=1): > > drivers/pci/controller/pci-hyperv.c:933:5: warning: > no previous prototype for ‘hv_read_config_block’ > [-Wmissing-prototypes] > > drivers/pci/controller/pci-hyperv.c:1013:5: warning: > no previous prototype for ‘hv_write_config_block’ > [-Wmissing-prototypes] > > drivers/pci/controller/pci-hyperv.c:1082:5: warning: > no previous prototype for ‘hv_register_block_invalidate’ > [-Wmissing-prototypes] > > Signed-off-by: Krzysztof Wilczynski <kw@linux.com> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> Thanks! ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] PCI: hv: Make functions static 2019-08-29 15:50 ` Haiyang Zhang @ 2019-09-04 14:27 ` Lorenzo Pieralisi 2019-09-04 14:36 ` Krzysztof Wilczynski 0 siblings, 1 reply; 10+ messages in thread From: Lorenzo Pieralisi @ 2019-09-04 14:27 UTC (permalink / raw) To: Haiyang Zhang Cc: Krzysztof Wilczynski, Bjorn Helgaas, KY Srinivasan, Stephen Hemminger, Sasha Levin, linux-pci, linux-kernel, linux-hyperv On Thu, Aug 29, 2019 at 03:50:47PM +0000, Haiyang Zhang wrote: > > > > -----Original Message----- > > From: Krzysztof Wilczynski <kswilczynski@gmail.com> On Behalf Of Krzysztof > > Wilczynski > > Sent: Thursday, August 29, 2019 2:17 AM > > To: Bjorn Helgaas <helgaas@kernel.org> > > Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang > > <haiyangz@microsoft.com>; Stephen Hemminger > > <sthemmin@microsoft.com>; Sasha Levin <sashal@kernel.org>; Lorenzo > > Pieralisi <lorenzo.pieralisi@arm.com>; linux-pci@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-hyperv@vger.kernel.org > > Subject: [PATCH v3] PCI: hv: Make functions static > > > > Functions hv_read_config_block(), hv_write_config_block() and > > hv_register_block_invalidate() are not used anywhere else and are local to > > drivers/pci/controller/pci-hyperv.c, > > and do not need to be in global scope, so make these static. > > > > Resolve following compiler warning that can be seen when building with > > warnings enabled (W=1): > > > > drivers/pci/controller/pci-hyperv.c:933:5: warning: > > no previous prototype for ‘hv_read_config_block’ > > [-Wmissing-prototypes] > > > > drivers/pci/controller/pci-hyperv.c:1013:5: warning: > > no previous prototype for ‘hv_write_config_block’ > > [-Wmissing-prototypes] > > > > drivers/pci/controller/pci-hyperv.c:1082:5: warning: > > no previous prototype for ‘hv_register_block_invalidate’ > > [-Wmissing-prototypes] > > > > Signed-off-by: Krzysztof Wilczynski <kw@linux.com> > > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> This patch should go via the net tree - the code it is fixing is queued there, I will drop this patch from the PCI review queue. If it helps: Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] PCI: hv: Make functions static 2019-09-04 14:27 ` Lorenzo Pieralisi @ 2019-09-04 14:36 ` Krzysztof Wilczynski 0 siblings, 0 replies; 10+ messages in thread From: Krzysztof Wilczynski @ 2019-09-04 14:36 UTC (permalink / raw) To: Lorenzo Pieralisi Cc: Haiyang Zhang, Bjorn Helgaas, KY Srinivasan, Stephen Hemminger, Sasha Levin, linux-pci, linux-kernel, linux-hyperv Hello Lorenzo, [...] > This patch should go via the net tree - the code it is fixing > is queued there, I will drop this patch from the PCI review > queue. [...] Thank you! Appreciated. Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c 2019-08-26 15:41 [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Krzysztof Wilczynski 2019-08-28 22:18 ` [PATCH v2] " Krzysztof Wilczynski @ 2019-08-28 22:26 ` Bjorn Helgaas 2019-08-28 23:33 ` Krzysztof Wilczynski 1 sibling, 1 reply; 10+ messages in thread From: Bjorn Helgaas @ 2019-08-28 22:26 UTC (permalink / raw) To: Krzysztof Wilczynski Cc: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Sasha Levin, Lorenzo Pieralisi, linux-pci, linux-kernel, linux-hyperv Maybe just: PCI: hv: Make functions static since we already know it's in pci-hyperv.c, and it's obvious that you can only do this for functions that are only used locally. On Mon, Aug 26, 2019 at 05:41:59PM +0200, Krzysztof Wilczynski wrote: > Functions hv_read_config_block(), hv_write_config_block() > and hv_register_block_invalidate() are not used anywhere > else and are local to drivers/pci/controller/pci-hyperv.c, > and do not need to be in global scope, so make these static. > > Resolve compiler warning that can be seen when building with > warnings enabled (W=1). Rewrap commit log to fill 75 columns. Does this fix all the similar warnings in drivers/pci/? If there are more, maybe we could fix them all in a single patch or at least a single series? > Signed-off-by: Krzysztof Wilczynski <kw@linux.com> > --- > drivers/pci/controller/pci-hyperv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > index f1f300218fab..c9642e429c2d 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -930,7 +930,7 @@ static void hv_pci_read_config_compl(void *context, struct pci_response *resp, > * > * Return: 0 on success, -errno on failure > */ > -int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > +static int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > unsigned int block_id, unsigned int *bytes_returned) > { > struct hv_pcibus_device *hbus = > @@ -1010,7 +1010,7 @@ static void hv_pci_write_config_compl(void *context, struct pci_response *resp, > * > * Return: 0 on success, -errno on failure > */ > -int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > +static int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > unsigned int block_id) > { > struct hv_pcibus_device *hbus = > @@ -1079,7 +1079,7 @@ int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len, > * > * Return: 0 on success, -errno on failure > */ > -int hv_register_block_invalidate(struct pci_dev *pdev, void *context, > +static int hv_register_block_invalidate(struct pci_dev *pdev, void *context, > void (*block_invalidate)(void *context, > u64 block_mask)) > { > -- > 2.22.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c 2019-08-28 22:26 ` [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Bjorn Helgaas @ 2019-08-28 23:33 ` Krzysztof Wilczynski 0 siblings, 0 replies; 10+ messages in thread From: Krzysztof Wilczynski @ 2019-08-28 23:33 UTC (permalink / raw) To: Bjorn Helgaas Cc: Krzysztof Wilczynski, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Sasha Levin, Lorenzo Pieralisi, linux-pci, linux-kernel, linux-hyperv Hello Bjorn, Thank you for feedback. [...] > Maybe just: > > PCI: hv: Make functions static > > since we already know it's in pci-hyperv.c, and it's obvious that you > can only do this for functions that are only used locally. Makes sense. I will update the subject line in v3. [...] > Rewrap commit log to fill 75 columns. Sorry about this. I wasn't sure if one also should wrap compiler and/or checkpatch.pl script warnings or errors. I will fix this. > Does this fix all the similar warnings in drivers/pci/? If there are > more, maybe we could fix them all in a single patch or at least a > single series? At the moment, while compiling the drivers/pci the compiler yields a similar warning for the following files: arch/x86/pci/xen.c arch/x86/pci/numachip.c drivers/pci/controller/pci-hyperv.c drivers/pci/vc.c I will have a look at each closer. Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-09-04 14:36 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-08-26 15:41 [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Krzysztof Wilczynski 2019-08-28 22:18 ` [PATCH v2] " Krzysztof Wilczynski 2019-08-28 22:32 ` Haiyang Zhang 2019-08-29 0:08 ` Krzysztof Wilczynski 2019-08-29 9:17 ` [PATCH v3] PCI: hv: Make functions static Krzysztof Wilczynski 2019-08-29 15:50 ` Haiyang Zhang 2019-09-04 14:27 ` Lorenzo Pieralisi 2019-09-04 14:36 ` Krzysztof Wilczynski 2019-08-28 22:26 ` [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Bjorn Helgaas 2019-08-28 23:33 ` Krzysztof Wilczynski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).