From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6410FC3A5A7 for ; Wed, 4 Sep 2019 14:27:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AE5D22DBF for ; Wed, 4 Sep 2019 14:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729803AbfIDO1t (ORCPT ); Wed, 4 Sep 2019 10:27:49 -0400 Received: from foss.arm.com ([217.140.110.172]:56462 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729809AbfIDO1s (ORCPT ); Wed, 4 Sep 2019 10:27:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8E7E1570; Wed, 4 Sep 2019 07:27:47 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8F7E93F59C; Wed, 4 Sep 2019 07:27:46 -0700 (PDT) Date: Wed, 4 Sep 2019 15:27:37 +0100 From: Lorenzo Pieralisi To: Haiyang Zhang Cc: Krzysztof Wilczynski , Bjorn Helgaas , KY Srinivasan , Stephen Hemminger , Sasha Levin , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" Subject: Re: [PATCH v3] PCI: hv: Make functions static Message-ID: <20190904142737.GA28184@e121166-lin.cambridge.arm.com> References: <20190828221846.6672-1-kw@linux.com> <20190829091713.27130-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Thu, Aug 29, 2019 at 03:50:47PM +0000, Haiyang Zhang wrote: > > > > -----Original Message----- > > From: Krzysztof Wilczynski On Behalf Of Krzysztof > > Wilczynski > > Sent: Thursday, August 29, 2019 2:17 AM > > To: Bjorn Helgaas > > Cc: KY Srinivasan ; Haiyang Zhang > > ; Stephen Hemminger > > ; Sasha Levin ; Lorenzo > > Pieralisi ; linux-pci@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-hyperv@vger.kernel.org > > Subject: [PATCH v3] PCI: hv: Make functions static > > > > Functions hv_read_config_block(), hv_write_config_block() and > > hv_register_block_invalidate() are not used anywhere else and are local to > > drivers/pci/controller/pci-hyperv.c, > > and do not need to be in global scope, so make these static. > > > > Resolve following compiler warning that can be seen when building with > > warnings enabled (W=1): > > > > drivers/pci/controller/pci-hyperv.c:933:5: warning: > > no previous prototype for ‘hv_read_config_block’ > > [-Wmissing-prototypes] > > > > drivers/pci/controller/pci-hyperv.c:1013:5: warning: > > no previous prototype for ‘hv_write_config_block’ > > [-Wmissing-prototypes] > > > > drivers/pci/controller/pci-hyperv.c:1082:5: warning: > > no previous prototype for ‘hv_register_block_invalidate’ > > [-Wmissing-prototypes] > > > > Signed-off-by: Krzysztof Wilczynski > > Reviewed-by: Haiyang Zhang This patch should go via the net tree - the code it is fixing is queued there, I will drop this patch from the PCI review queue. If it helps: Acked-by: Lorenzo Pieralisi