From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B34A2C3A5A6 for ; Mon, 23 Sep 2019 08:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 850D320820 for ; Mon, 23 Sep 2019 08:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569229090; bh=joT5jN9AFygxjefg+dRj2T5R2SmM0kBjnYWY1WU/WC4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WNxk3fJipC4wP6trP0EN46vOPZLo9OVvXzyrAEcC6of2AT5Il/8Sp22NYpBMfNs63 CTaIAbXIzOFE4vewU+Qr6HKFusK7sBo3Rv5EIfO0A2+pp2/++8KMiWoVXLLPUKLpxG hYZpTG7wuWswy0vry9LOhLLGqWmDFjQ/WiZPbJaE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731393AbfIWI6K (ORCPT ); Mon, 23 Sep 2019 04:58:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:51152 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729483AbfIWI6J (ORCPT ); Mon, 23 Sep 2019 04:58:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E41CEAAB2; Mon, 23 Sep 2019 08:58:07 +0000 (UTC) Date: Mon, 23 Sep 2019 10:58:07 +0200 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Souptick Joarder , linux-hyperv@vger.kernel.org, Andrew Morton , Dan Williams , Haiyang Zhang , "K. Y. Srinivasan" , Oscar Salvador , Pavel Tatashin , Qian Cai , Sasha Levin , Stephen Hemminger , Wei Yang Subject: Re: [PATCH v1 0/3] mm/memory_hotplug: Export generic_online_page() Message-ID: <20190923085807.GD6016@dhcp22.suse.cz> References: <20190909114830.662-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Fri 20-09-19 10:17:54, David Hildenbrand wrote: > On 09.09.19 13:48, David Hildenbrand wrote: > > Based on linux/next + "[PATCH 0/3] Remove __online_page_set_limits()" > > > > Let's replace the __online_page...() functions by generic_online_page(). > > Hyper-V only wants to delay the actual onlining of un-backed pages, so we > > can simpy re-use the generic function. > > > > Only compile-tested. > > > > Cc: Souptick Joarder > > > > David Hildenbrand (3): > > mm/memory_hotplug: Export generic_online_page() > > hv_balloon: Use generic_online_page() > > mm/memory_hotplug: Remove __online_page_free() and > > __online_page_increment_counters() > > > > drivers/hv/hv_balloon.c | 3 +-- > > include/linux/memory_hotplug.h | 4 +--- > > mm/memory_hotplug.c | 17 ++--------------- > > 3 files changed, 4 insertions(+), 20 deletions(-) > > > > Ping, any comments on this one? Unification makes a lot of sense to me. You can add Acked-by: Michal Hocko I will most likely won't surprise if I asked for more here though ;) I have to confess I really detest the whole concept of a hidden callback with a very weird API. Is this something we can do about? I do realize that adding a callback would require either cluttering the existing APIs but maybe we can come up with something more clever. Or maybe existing external users of online callback can do that as a separate step after the online is completed - or is this impossible due to locking guarantees? -- Michal Hocko SUSE Labs