From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F75C47404 for ; Fri, 4 Oct 2019 15:48:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 076F320830 for ; Fri, 4 Oct 2019 15:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570204104; bh=S2WPOl/0NG3P+Mug85lHlPzdbG1nDs6G5hw05L4rq7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QuoReRtekI9JxzURd6eGvnbNBOAETIBXndh0XsXq7qpL6wljzcmJlBNi/ejl1jsbk mCI6/5VYKgkJbrZDnlnSQi7uTUq94JkKT2NovTJ1YDymlMnrvaB1+yw07QItnC9vVY N5eQcTwGusaQ82dK3FkX6cAT+rWZpJNwQuWd/27E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390025AbfJDPsT (ORCPT ); Fri, 4 Oct 2019 11:48:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:36922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389794AbfJDPsT (ORCPT ); Fri, 4 Oct 2019 11:48:19 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 287A020830; Fri, 4 Oct 2019 15:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570204098; bh=S2WPOl/0NG3P+Mug85lHlPzdbG1nDs6G5hw05L4rq7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gogeOTWhbb1G6lu8oXCbTK9S5PfIvspwQwfnbqhWBqa+hQQ8IKcyDwvPGeG08EnqQ qzDzKdG8vwYJM4Gn4OJSHW/FacZhCbzhEfQh8si6Yf/+0VN2jz5CTXRMRZd1ZleDh3 vIJiykQYVLi5JEY2ueqXlhGTh0sp5nL6lh/SrZDY= Date: Fri, 4 Oct 2019 11:48:17 -0400 From: Sasha Levin To: Michael Kelley Cc: Himadri Pandya , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "davem@davemloft.net" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "himadri18.07" Subject: Re: [PATCH] hv_sock: use HV_HYP_PAGE_SIZE instead of PAGE_SIZE_4K Message-ID: <20191004154817.GL17454@sasha-vm> References: <20190725051125.10605-1-himadri18.07@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, Jul 31, 2019 at 01:02:03AM +0000, Michael Kelley wrote: >From: Himadri Pandya Sent: Wednesday, July 24, 2019 10:11 PM >> >> Older windows hosts require the hv_sock ring buffer to be defined >> using 4K pages. This was achieved by using the symbol PAGE_SIZE_4K >> defined specifically for this purpose. But now we have a new symbol >> HV_HYP_PAGE_SIZE defined in hyperv-tlfs which can be used for this. >> >> This patch removes the definition of symbol PAGE_SIZE_4K and replaces >> its usage with the symbol HV_HYP_PAGE_SIZE. This patch also aligns >> sndbuf and rcvbuf to hyper-v specific page size using HV_HYP_PAGE_SIZE >> instead of the guest page size(PAGE_SIZE) as hyper-v expects the page >> size to be 4K and it might not be the case on ARM64 architecture. >> >> Signed-off-by: Himadri Pandya >> --- >> net/vmw_vsock/hyperv_transport.c | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) >> >> diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c >> index f2084e3f7aa4..ecb5d72d8010 100644 >> --- a/net/vmw_vsock/hyperv_transport.c >> +++ b/net/vmw_vsock/hyperv_transport.c >> @@ -13,15 +13,16 @@ >> #include >> #include >> #include >> +#include >> > >Reviewed-by: Michael Kelley > >This patch depends on a prerequisite patch in > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/hyperv > >that defines HV_HYP_PAGE_SIZE. David, the above prerequisite patch is now upstream, so this patch should be good to go. Would you take it through the net tree or should I do it via the hyperv tree? -- Thanks, Sasha