From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64AC5C432C0 for ; Tue, 19 Nov 2019 13:23:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34A97222C2 for ; Tue, 19 Nov 2019 13:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574169810; bh=KuVVClqX8tsVfH+5W3FLR+U/sFzRduxkNvUYuYq4oQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HLO8bD3Va/TyrqagLer978T/dy3yD5/HGVvp6rlexZf8oTU8zHQlggzpoZKLb6gt6 +KYSGzg++M1mVX7xQjsbHiM9Q5wXBLi/MZRUH0dL1Ghn3cz0OQgx31suAda1BnUHN/ XLq3LkWUQEOa7CANbkQDv8assyxzIAbddkVgDo9I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbfKSNXa (ORCPT ); Tue, 19 Nov 2019 08:23:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:53772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfKSNX3 (ORCPT ); Tue, 19 Nov 2019 08:23:29 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EDDDC2080F; Tue, 19 Nov 2019 13:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574169809; bh=KuVVClqX8tsVfH+5W3FLR+U/sFzRduxkNvUYuYq4oQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hiE8XEJmou9/ZrBT8NlxamTWukBVCrTIFa/eOP4HsNpjt4Ry9PJuOmkGAQzFtje8E dDsYNs++9ogGaBD61ybRs2LBg3g5nGdAo0Cmq3Fpj0A3LPtVtAXvRcd2GHfbLeYLx3 g8iT39gkDQvcTH0jofkbOgj0B3WD4dMA5VrACuFA= Date: Tue, 19 Nov 2019 08:23:28 -0500 From: Sasha Levin To: Michael Kelley Cc: "linux-kernel@vger.kernel.org" , vkuznets , KY Srinivasan , Stephen Hemminger , Dexuan Cui , "linux-hyperv@vger.kernel.org" Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix crash handler reset of Hyper-V synic Message-ID: <20191119132328.GF16867@sasha-vm> References: <1573713076-8446-1-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1573713076-8446-1-git-send-email-mikelley@microsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Thu, Nov 14, 2019 at 06:32:01AM +0000, Michael Kelley wrote: >The crash handler calls hv_synic_cleanup() to shutdown the >Hyper-V synthetic interrupt controller. But if the CPU >that calls hv_synic_cleanup() has a VMbus channel interrupt >assigned to it (which is likely the case in smaller VM sizes), >hv_synic_cleanup() returns an error and the synthetic >interrupt controller isn't shutdown. While the lack of >being shutdown hasn't caused a known problem, it still >should be fixed for highest reliability. > >So directly call hv_synic_disable_regs() instead of >hv_synic_cleanup(), which ensures that the synic is always >shutdown. > >Signed-off-by: Michael Kelley Queued up, thank you. -- Thanks, Sasha