From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 587A4C33CB6 for ; Thu, 16 Jan 2020 17:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 277AD24683 for ; Thu, 16 Jan 2020 17:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195983; bh=6StsNdWuSYEL+GQ4LyCBoI2E6aXirUVS+EBT1x5Ua5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xpeB+c/2sjPX7y6+UwCgMRBUhH0aDYZkL8c8aMzIgVSzln4TqrfmV8IwAnhWH3B6y N57wGfhAU23Vw9p4mSSqlP2Yz/Fxg2aFsdZ+KMu+ycGebnwLJ+e+SY0C6H1yvgYHAr 1ZoWIuT96JiIa1OEMzyayG5MP1yE8iFRlkZjGvtA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404620AbgAPRdC (ORCPT ); Thu, 16 Jan 2020 12:33:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:43552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392991AbgAPRao (ORCPT ); Thu, 16 Jan 2020 12:30:44 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EFAC024713; Thu, 16 Jan 2020 17:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195844; bh=6StsNdWuSYEL+GQ4LyCBoI2E6aXirUVS+EBT1x5Ua5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PAJfGziRZLzpRa0CvQ+9/iy+S//iHAfmx8X8kpRYaHOS+GUdNQ7gdAby1yrnTdY5G n/hJLCYC9jpm42YjabZ5W/dIaWs27E/TKiWUIfqzjQFjZMRdYfiJlfjKSlJfe/Lp0/ kADIXPXBhW6UosMk8+XO/KZTTJgp7oADp+2Ag228= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stephen Hemminger , "David S . Miller" , Sasha Levin , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 345/371] hv_netvsc: flag software created hash value Date: Thu, 16 Jan 2020 12:23:37 -0500 Message-Id: <20200116172403.18149-288-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org From: Stephen Hemminger [ Upstream commit df9f540ca74297a84bafacfa197e9347b20beea5 ] When the driver needs to create a hash value because it was not done at higher level, then the hash should be marked as a software not hardware hash. Fixes: f72860afa2e3 ("hv_netvsc: Exclude non-TCP port numbers from vRSS hashing") Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/hyperv/netvsc_drv.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 9e48855f6407..14451e14d99d 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -282,9 +282,9 @@ static inline u32 netvsc_get_hash( else if (flow.basic.n_proto == htons(ETH_P_IPV6)) hash = jhash2((u32 *)&flow.addrs.v6addrs, 8, hashrnd); else - hash = 0; + return 0; - skb_set_hash(skb, hash, PKT_HASH_TYPE_L3); + __skb_set_sw_hash(skb, hash, false); } return hash; @@ -802,8 +802,7 @@ static struct sk_buff *netvsc_alloc_recv_skb(struct net_device *net, skb->protocol == htons(ETH_P_IP)) netvsc_comp_ipcsum(skb); - /* Do L4 checksum offload if enabled and present. - */ + /* Do L4 checksum offload if enabled and present. */ if (csum_info && (net->features & NETIF_F_RXCSUM)) { if (csum_info->receive.tcp_checksum_succeeded || csum_info->receive.udp_checksum_succeeded) -- 2.20.1