* [PATCH] Driver: hv: vmbus: drop a no long applicable comment
@ 2020-05-06 16:08 Wei Liu
2020-05-06 17:49 ` Michael Kelley
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2020-05-06 16:08 UTC (permalink / raw)
To: linux-hyperv
Cc: linux-kernel, mikelley, Wei Liu, K. Y. Srinivasan, Haiyang Zhang,
Stephen Hemminger
None of the things mentioned in the comment is initialized in hv_init.
They've been moved elsewhere.
Signed-off-by: Wei Liu <wei.liu@kernel.org>
---
drivers/hv/vmbus_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 3a27f6c5f3de..7efdcadc335e 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1396,7 +1396,6 @@ static int vmbus_bus_init(void)
{
int ret;
- /* Hypervisor initialization...setup hypercall page..etc */
ret = hv_init();
if (ret != 0) {
pr_err("Unable to initialize the hypervisor - 0x%x\n", ret);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] Driver: hv: vmbus: drop a no long applicable comment
2020-05-06 16:08 [PATCH] Driver: hv: vmbus: drop a no long applicable comment Wei Liu
@ 2020-05-06 17:49 ` Michael Kelley
2020-05-07 10:36 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2020-05-06 17:49 UTC (permalink / raw)
To: Wei Liu, linux-hyperv
Cc: linux-kernel, KY Srinivasan, Haiyang Zhang, Stephen Hemminger
From: Wei Liu <wei.liu@kernel.org> Sent: Wednesday, May 6, 2020 9:08 AM
>
> None of the things mentioned in the comment is initialized in hv_init.
> They've been moved elsewhere.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> ---
> drivers/hv/vmbus_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 3a27f6c5f3de..7efdcadc335e 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1396,7 +1396,6 @@ static int vmbus_bus_init(void)
> {
> int ret;
>
> - /* Hypervisor initialization...setup hypercall page..etc */
> ret = hv_init();
> if (ret != 0) {
> pr_err("Unable to initialize the hypervisor - 0x%x\n", ret);
> --
> 2.20.1
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Driver: hv: vmbus: drop a no long applicable comment
2020-05-06 17:49 ` Michael Kelley
@ 2020-05-07 10:36 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2020-05-07 10:36 UTC (permalink / raw)
To: Michael Kelley
Cc: Wei Liu, linux-hyperv, linux-kernel, KY Srinivasan,
Haiyang Zhang, Stephen Hemminger
On Wed, May 06, 2020 at 05:49:05PM +0000, Michael Kelley wrote:
> From: Wei Liu <wei.liu@kernel.org> Sent: Wednesday, May 6, 2020 9:08 AM
> >
> > None of the things mentioned in the comment is initialized in hv_init.
> > They've been moved elsewhere.
> >
> > Signed-off-by: Wei Liu <wei.liu@kernel.org>
> > ---
> > drivers/hv/vmbus_drv.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > index 3a27f6c5f3de..7efdcadc335e 100644
> > --- a/drivers/hv/vmbus_drv.c
> > +++ b/drivers/hv/vmbus_drv.c
> > @@ -1396,7 +1396,6 @@ static int vmbus_bus_init(void)
> > {
> > int ret;
> >
> > - /* Hypervisor initialization...setup hypercall page..etc */
> > ret = hv_init();
> > if (ret != 0) {
> > pr_err("Unable to initialize the hypervisor - 0x%x\n", ret);
> > --
> > 2.20.1
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>
Thanks.
Applied to hyperv-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-07 10:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 16:08 [PATCH] Driver: hv: vmbus: drop a no long applicable comment Wei Liu
2020-05-06 17:49 ` Michael Kelley
2020-05-07 10:36 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).