From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C22C433E0 for ; Tue, 16 Jun 2020 13:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF34420C56 for ; Tue, 16 Jun 2020 13:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592314101; bh=o16TOGaXPe+mfeD5YOCp9VLSgp7Z61k04+2zqhJahyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JzV8USpTtReMy7Htc8wB5sGSdzM0DlHaHYyMyiJoEYgEItHKYKtSUQt6WMlU3o3MA N0xFaDBHRxX1U+MGlQR5UH2oK1c4U/bpqvj3TMfmtM0ZBTkNnMmRUkO+BRdh0tbYcw fYbBLcla2gxWXjvKHUdDWQoGNEwlXu9RG9lEwhto= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728553AbgFPN2V (ORCPT ); Tue, 16 Jun 2020 09:28:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:46000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbgFPN2U (ORCPT ); Tue, 16 Jun 2020 09:28:20 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B1112098B; Tue, 16 Jun 2020 13:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592314100; bh=o16TOGaXPe+mfeD5YOCp9VLSgp7Z61k04+2zqhJahyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gmnWwjuC907MuTP3R+2w7BNh+0ddDUn+NqTB5TaBAoT7R2ybKpoEoWwLY0dd+TVCG UduXuIMIx8j0qk8c0CJ2LoxjuS+pdutttJszGgZSDYkwQKoDV12+4BnAJuEhWkXpsz YGAY/pQsAevEClH4v5C0DdhhMGZOvk8oZRgb+EdU= Date: Tue, 16 Jun 2020 09:28:19 -0400 From: Sasha Levin To: Pavel Machek Cc: Thomas Zimmermann , alexander.deucher@amd.com, chris@chris-wilson.co.uk, ville.syrjala@linux.intel.com, Hawking.Zhang@amd.com, tvrtko.ursulin@intel.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, spronovo@microsoft.com, iourit@microsoft.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [RFC PATCH 0/4] DirectX on Linux Message-ID: <20200616132819.GP1931@sasha-vm> References: <20200519163234.226513-1-sashal@kernel.org> <55c57049-1869-7421-aa0f-3ce0b6a133cf@suse.de> <20200616105112.GC1718@bug> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200616105112.GC1718@bug> Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote: >Hi! > >> > The driver creates the /dev/dxg device, which can be opened by user mode >> > application and handles their ioctls. The IOCTL interface to the driver >> > is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl >> > definitions). The interface matches the D3DKMT interface on Windows. >> > Ioctls are implemented in ioctl.c. >> >> Echoing what others said, you're not making a DRM driver. The driver should live outside >> of the DRM code. >> > >Actually, this sounds to me like "this should not be merged into linux kernel". I mean, >we already have DRM API on Linux. We don't want another one, do we? This driver doesn't have any display functionality. >And at the very least... this misses API docs for /dev/dxg. Code can't really >be reviewed without that. The docs live here: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/d3dkmthk/ -- Thanks, Sasha