From: Wei Liu <wei.liu@kernel.org>
To: Joseph Salisbury <joseph.salisbury@microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, sashal@kernel.org, wei.liu@kernel.org,
mikelley@microsoft.com, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH][v2] Drivers: hv: Change flag to write log level in panic msg to false
Date: Mon, 29 Jun 2020 10:32:23 +0000 [thread overview]
Message-ID: <20200629103223.ft7l76vbr45eec6x@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1593210497-114310-1-git-send-email-joseph.salisbury@microsoft.com>
On Fri, Jun 26, 2020 at 03:28:17PM -0700, Joseph Salisbury wrote:
> When the kernel panics, one page of kmsg data may be collected and sent to
> Hyper-V to aid in diagnosing the failure. The collected kmsg data typically
> contains 50 to 100 lines, each of which has a log level prefix that isn't
> very useful from a diagnostic standpoint. So tell kmsg_dump_get_buffer()
> to not include the log level, enabling more information that *is* useful to
> fit in the page.
>
> Requesting in stable kernels, since many kernels running in production are
> stable releases.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
Applied to hyperv-fixes with Michael's review from v1. Thanks.
> ---
> drivers/hv/vmbus_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 9147ee9d5f7d..d69f4efa3719 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1368,7 +1368,7 @@ static void hv_kmsg_dump(struct kmsg_dumper *dumper,
> * Write dump contents to the page. No need to synchronize; panic should
> * be single-threaded.
> */
> - kmsg_dump_get_buffer(dumper, true, hv_panic_page, HV_HYP_PAGE_SIZE,
> + kmsg_dump_get_buffer(dumper, false, hv_panic_page, HV_HYP_PAGE_SIZE,
> &bytes_written);
> if (bytes_written)
> hyperv_report_panic_msg(panic_pa, bytes_written);
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-06-29 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 22:28 [PATCH][v2] Drivers: hv: Change flag to write log level in panic msg to false Joseph Salisbury
2020-06-29 10:32 ` Wei Liu [this message]
2020-07-01 19:33 ` Sasha Levin
2020-07-06 10:55 ` Wei Liu
2020-07-06 11:46 ` Wei Liu
2020-07-06 13:28 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629103223.ft7l76vbr45eec6x@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=haiyangz@microsoft.com \
--cc=joseph.salisbury@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).