From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7B3C433E0 for ; Mon, 29 Jun 2020 22:26:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FC0420702 for ; Mon, 29 Jun 2020 22:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593469586; bh=r3VNIG9zdZCG6XvWpYgndcaV7QVuq/DRgpAllK4xRQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FMnhWTbWADLYIksXebYbY4RhdbJnaCSe31sxkm+wjX/5Ia9BRDy5jaFasDx1dqFnj yxb4I9TaErWEwB72ePBhBAeHAUoHFce+KhF+l150R4GJDPkh+YA6mghBDEuZcQloY+ qAq501w+MwMyVqOhiDIFVcqqsjFcTqd0Vxa1W7aE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731120AbgF2W0U (ORCPT ); Mon, 29 Jun 2020 18:26:20 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43468 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726974AbgF2W0Q (ORCPT ); Mon, 29 Jun 2020 18:26:16 -0400 Received: by mail-wr1-f65.google.com with SMTP id j4so15722036wrp.10; Mon, 29 Jun 2020 15:26:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LM1EvBQFJ9bPWFgzrCK4QStJDhC6i50g59dK2Gr0iyU=; b=tMMqM+HQKgSxCC6qxUEiXizZKpfYmchK8eG9+/kz2O+6hcm2ld2FIk5/S1Oen9uL6D 30doifklRzqkrZMtNWxzmYGXv2n4kckt7KW9SS0LuD6Ch6mAawfPmYcCcoXGjC2iUMKj VNvjU7ncAAZmZNUdm3tlMCQDVdGQS2+dMu+AMgtIeXCZ88ruU1PwC7iXbx0RClBzfFbV oTWWbzPplnpViJhjgBwNPgqQX0Iz8Vpq18LFIyG6UpEjNWdINYNmgFSh6scczJTvodHF OUUiCOj2lj6M7pB+SIHXHWrKgBJlf0v4dmTR/T0aM3VXqkX82gEDdeTaj/Ujffiy0aOn PxlA== X-Gm-Message-State: AOAM531feytHhiJCifclKZWikq1kKcdO/uoxZ3UBqvvd8WYrLDyDI5WH VgnVoMmvPF6XdckqOeh8szTBe+ZH X-Google-Smtp-Source: ABdhPJwf3d8ZkBU7ZHjIKV/HaftDPM+aqerSKsrHstUj5ydiwXM7tnHAsu5OI7a05IGATlxo7H/BUQ== X-Received: by 2002:adf:84e2:: with SMTP id 89mr19764045wrg.139.1593469574388; Mon, 29 Jun 2020 15:26:14 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id 138sm1430837wma.23.2020.06.29.15.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 15:26:13 -0700 (PDT) Date: Mon, 29 Jun 2020 22:26:12 +0000 From: Wei Liu To: Haiyang Zhang Cc: Andres Beltran , KY Srinivasan , Stephen Hemminger , "wei.liu@kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michael Kelley , "parri.andrea@gmail.com" , "David S . Miller" , Jakub Kicinski , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening Message-ID: <20200629222612.pxbuuifod6tyudfu@liuwe-devbox-debian-v2> References: <20200629200227.1518784-1-lkmlabelt@gmail.com> <20200629200227.1518784-4-lkmlabelt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Mon, Jun 29, 2020 at 09:33:15PM +0000, Haiyang Zhang wrote: > > > > -----Original Message----- > > From: Andres Beltran > > Sent: Monday, June 29, 2020 4:02 PM > > To: KY Srinivasan ; Haiyang Zhang > > ; Stephen Hemminger ; > > wei.liu@kernel.org > > Cc: linux-hyperv@vger.kernel.org; linux-kernel@vger.kernel.org; Michael > > Kelley ; parri.andrea@gmail.com; Andres Beltran > > ; David S . Miller ; Jakub > > Kicinski ; netdev@vger.kernel.org > > Subject: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate > > transaction IDs for VMBus hardening > > > > Currently, pointers to guest memory are passed to Hyper-V as > > transaction IDs in netvsc. In the face of errors or malicious > > behavior in Hyper-V, netvsc should not expose or trust the transaction > > IDs returned by Hyper-V to be valid guest memory addresses. Instead, > > use small integers generated by vmbus_requestor as requests > > (transaction) IDs. > > > > Cc: David S. Miller > > Cc: Jakub Kicinski > > Cc: netdev@vger.kernel.org > > Signed-off-by: Andres Beltran > > Reviewed-by: Haiyang Zhang > > Thanks Haiyang for reviewing. David and Jakub: This patch depends on the first patch. I intend to pick up this patch via hyperv.git. This makes life easier for all of us. Let me know if you disagree. Wei.