From: David Miller <davem@davemloft.net>
To: Song.Chi@microsoft.com
Cc: haiyangz@microsoft.com, kys@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, kuba@kernel.org,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 net-next] net: hyperv: Add attributes to show TX indirection table
Date: Mon, 20 Jul 2020 20:14:00 -0700 (PDT) [thread overview]
Message-ID: <20200720.201400.1580393372170110087.davem@davemloft.net> (raw)
In-Reply-To: <HK0P153MB02751820DD4F8892DEFA13D098780@HK0P153MB0275.APCP153.PROD.OUTLOOK.COM>
From: Chi Song <Song.Chi@microsoft.com>
Date: Tue, 21 Jul 2020 02:37:42 +0000
> +static ssize_t tx_indirection_show(struct device *dev,
> + struct device_attribute *dev_attr, char *buf)
> +{
> + struct net_device *ndev = to_net_dev(dev);
> + struct net_device_context *ndc = netdev_priv(ndev);
> + int index = dev_attr - dev_attr_netvsc_dev_attrs;
Reverse christmas tree ordering for local variables please.
> +static void netvsc_attrs_init(void)
> +{
> + int i;
> + char buffer[4];
Likewise.
prev parent reply other threads:[~2020-07-21 3:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 2:37 [PATCH v4 net-next] net: hyperv: Add attributes to show TX indirection table Chi Song
2020-07-21 3:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720.201400.1580393372170110087.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Song.Chi@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).