From: Wei Liu <wei.liu@kernel.org>
To: Michael Kelley <mikelley@microsoft.com>
Cc: Olaf Hering <olaf@aepfle.de>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH v1] hv_balloon: disable warning when floor reached
Date: Mon, 19 Oct 2020 13:42:09 +0000 [thread overview]
Message-ID: <20201019134209.fgjlip52k5xayr2w@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <MW2PR2101MB1052BA9AB5DB8C11D7F9CE33D71E0@MW2PR2101MB1052.namprd21.prod.outlook.com>
On Mon, Oct 19, 2020 at 03:02:22AM +0000, Michael Kelley wrote:
> From: Olaf Hering <olaf@aepfle.de> Sent: Thursday, October 8, 2020 12:12 AM
> >
> > It is not an error if a the host requests to balloon down, but the VM
>
> Spurious word "a"
>
> > refuses to do so. Without this change a warning is logged in dmesg
> > every five minutes.
> >
> > Fixes commit b3bb97b8a49f3
>
> This "Fixes" line isn't formatted correctly. Should be:
>
> Fixes: b3bb97b8a49f3 ("Drivers: hv: balloon: Add logging for dynamic memory operations")
>
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > ---
> > drivers/hv/hv_balloon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> > index 32e3bc0aa665..0f50295d0214 100644
> > --- a/drivers/hv/hv_balloon.c
> > +++ b/drivers/hv/hv_balloon.c
> > @@ -1275,7 +1275,7 @@ static void balloon_up(struct work_struct *dummy)
> >
> > /* Refuse to balloon below the floor. */
> > if (avail_pages < num_pages || avail_pages - num_pages < floor) {
> > - pr_warn("Balloon request will be partially fulfilled. %s\n",
> > + pr_info("Balloon request will be partially fulfilled. %s\n",
> > avail_pages < num_pages ? "Not enough memory." :
> > "Balloon floor reached.");
> >
>
> Above nits notwithstanding,
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Thanks. I see one for and no against so far.
I've applied this patch to hyperv-fixes. I also fixed those nits
while at it.
Wei.
prev parent reply other threads:[~2020-10-19 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 7:12 [PATCH v1] hv_balloon: disable warning when floor reached Olaf Hering
2020-10-08 7:15 ` Olaf Hering
2020-10-13 9:17 ` Wei Liu
2020-10-13 9:19 ` Olaf Hering
2020-10-13 9:40 ` Wei Liu
2020-10-19 2:58 ` Michael Kelley
2020-10-19 6:56 ` Olaf Hering
2020-10-13 11:55 ` Olaf Hering
2020-10-19 3:02 ` Michael Kelley
2020-10-19 13:42 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019134209.fgjlip52k5xayr2w@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).