From: Siddharth Chandrasekaran <sidcha@amazon.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Wei Liu <wei.liu@kernel.org>, <kys@microsoft.com>,
<haiyangz@microsoft.com>, <sthemmin@microsoft.com>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<x86@kernel.org>, <hpa@zytor.com>, <seanjc@google.com>,
<vkuznets@redhat.com>, <wanpengli@tencent.com>,
<jmattson@google.com>, <joro@8bytes.org>, <graf@amazon.com>,
<eyakovl@amazon.de>, <linux-hyperv@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH 0/4] Add support for XMM fast hypercalls
Date: Thu, 8 Apr 2021 17:54:43 +0200 [thread overview]
Message-ID: <20210408155442.GC32315@u366d62d47e3651.ant.amazon.com> (raw)
In-Reply-To: <53200f24-bd57-1509-aee2-0723aa8a3f6f@redhat.com>
On Thu, Apr 08, 2021 at 05:48:19PM +0200, Paolo Bonzini wrote:
> On 08/04/21 17:40, Siddharth Chandrasekaran wrote:
> > > > > Although the Hyper-v TLFS mentions that a guest cannot use this feature
> > > > > unless the hypervisor advertises support for it, some hypercalls which
> > > > > we plan on upstreaming in future uses them anyway.
> > > > No, please don't do this. Check the feature bit(s) before you issue
> > > > hypercalls which rely on the extended interface.
> > > Perhaps Siddharth should clarify this, but I read it as Hyper-V being
> > > buggy and using XMM arguments unconditionally.
> > The guest is at fault here as it expects Hyper-V to consume arguments
> > from XMM registers for certain hypercalls (that we are working) even if
> > we didn't expose the feature via CPUID bits.
>
> What guest is that?
It is a Windows Server 2016.
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2021-04-08 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 21:29 [PATCH 0/4] Add support for XMM fast hypercalls Siddharth Chandrasekaran
2021-04-08 15:28 ` Wei Liu
2021-04-08 15:30 ` Paolo Bonzini
2021-04-08 15:38 ` Wei Liu
2021-04-08 16:21 ` Siddharth Chandrasekaran
2021-04-08 15:40 ` Siddharth Chandrasekaran
2021-04-08 15:48 ` Paolo Bonzini
2021-04-08 15:54 ` Siddharth Chandrasekaran [this message]
2021-04-08 16:30 ` Wei Liu
2021-04-08 17:45 ` Siddharth Chandrasekaran
2021-04-09 7:42 ` Vitaly Kuznetsov
2021-04-09 7:59 ` Siddharth Chandrasekaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408155442.GC32315@u366d62d47e3651.ant.amazon.com \
--to=sidcha@amazon.de \
--cc=bp@alien8.de \
--cc=eyakovl@amazon.de \
--cc=graf@amazon.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).