From: Wei Liu <wei.liu@kernel.org>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dexuan Cui <decui@microsoft.com>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Drivers: hv: vmbus: Use after free in __vmbus_open()
Date: Fri, 16 Apr 2021 10:37:24 +0000 [thread overview]
Message-ID: <20210416103724.f3unhyu72pbp2qr3@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20210413154221.GA2369@anparri>
On Tue, Apr 13, 2021 at 05:42:21PM +0200, Andrea Parri wrote:
> On Tue, Apr 13, 2021 at 01:50:04PM +0300, Dan Carpenter wrote:
> > The "open_info" variable is added to the &vmbus_connection.chn_msg_list,
> > but the error handling frees "open_info" without removing it from the
> > list. This will result in a use after free. First remove it from the
> > list, and then free it.
> >
> > Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I had this 'queued' in my list,
>
> Reviewed-by: Andrea Parri <parri.andrea@gmail.com>
Applied. Thanks.
prev parent reply other threads:[~2021-04-16 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 10:50 [PATCH] Drivers: hv: vmbus: Use after free in __vmbus_open() Dan Carpenter
2021-04-13 11:46 ` Wei Liu
2021-04-13 15:42 ` Andrea Parri
2021-04-16 10:37 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416103724.f3unhyu72pbp2qr3@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).