From: Wei Liu <wei.liu@kernel.org>
To: Michael Kelley <mikelley@microsoft.com>
Cc: Joseph Salisbury <Joseph.Salisbury@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drivers: hv: Create a consistent pattern for checking Hyper-V hypercall status
Date: Wed, 21 Apr 2021 09:47:27 +0000 [thread overview]
Message-ID: <20210421094727.ulbzt7uktpxfw4hg@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <MWHPR21MB15936E55F2A6FD6994DC4F34D7489@MWHPR21MB1593.namprd21.prod.outlook.com>
On Tue, Apr 20, 2021 at 09:30:08PM +0000, Michael Kelley wrote:
> From: Joseph Salisbury <joseph.salisbury@linux.microsoft.com> Sent: Friday, April 16, 2021 5:43 PM
> >
> > There is not a consistent pattern for checking Hyper-V hypercall status.
> > Existing code uses a number of variants. The variants work, but a consistent
> > pattern would improve the readability of the code, and be more conformant
> > to what the Hyper-V TLFS says about hypercall status.
> >
> > Implemented new helper functions hv_result(), hv_result_success(), and
> > hv_repcomp(). Changed the places where hv_do_hypercall() and related variants
> > are used to use the helper functions.
> >
> > Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
> > ---
> > arch/x86/hyperv/hv_apic.c | 16 +++++++++-------
> > arch/x86/hyperv/hv_init.c | 2 +-
> > arch/x86/hyperv/hv_proc.c | 25 ++++++++++---------------
> > arch/x86/hyperv/irqdomain.c | 6 +++---
> > arch/x86/hyperv/mmu.c | 8 ++++----
> > arch/x86/hyperv/nested.c | 8 ++++----
> > arch/x86/include/asm/mshyperv.h | 1 +
> > drivers/hv/hv.c | 2 +-
> > drivers/pci/controller/pci-hyperv.c | 2 +-
> > include/asm-generic/mshyperv.h | 25 ++++++++++++++++++++-----
> > 10 files changed, 54 insertions(+), 41 deletions(-)
>
> Wei -- I have gone through these changes reasonably carefully, but
> your review of the Linux-in-the-root-partition changes would be a good
> double-check. It's too easy to get the sense of the tests backwards. :-(
The code looks correct to me.
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Thanks. I will apply this series to hyperv-next shortly.
Wei.
next prev parent reply other threads:[~2021-04-21 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 0:43 [PATCH 1/2] x86/hyperv: Move hv_do_rep_hypercall to asm-generic Joseph Salisbury
2021-04-17 0:43 ` [PATCH 2/2] drivers: hv: Create a consistent pattern for checking Hyper-V hypercall status Joseph Salisbury
2021-04-20 21:30 ` Michael Kelley
2021-04-21 9:47 ` Wei Liu [this message]
2021-04-18 13:09 ` [PATCH 1/2] x86/hyperv: Move hv_do_rep_hypercall to asm-generic Wei Liu
2021-04-18 14:42 ` Michael Kelley
2021-04-18 15:35 ` Wei Liu
2021-04-20 21:25 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421094727.ulbzt7uktpxfw4hg@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=Joseph.Salisbury@microsoft.com \
--cc=bp@alien8.de \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).