linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hv: Remove unused inline functions in hyperv.h
@ 2021-07-21 21:41 Sonia Sharma
  2021-07-22  5:35 ` Michael Kelley
  0 siblings, 1 reply; 3+ messages in thread
From: Sonia Sharma @ 2021-07-21 21:41 UTC (permalink / raw)
  To: K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu,
	Dexuan Cui, linux-hyperv, linux-kernel, Sonia Sharma

From: Sonia Sharma <sonia.sharma@microsoft.com>

There are some unused inline functions in hyperv header file.
Remove those unused functions.

Signed-off-by: Sonia Sharma <sonia.sharma@microsoft.com>
---
 include/linux/hyperv.h | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 2e859d2..ddc8713 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -538,12 +538,6 @@ struct vmbus_channel_rescind_offer {
 	u32 child_relid;
 } __packed;
 
-static inline u32
-hv_ringbuffer_pending_size(const struct hv_ring_buffer_info *rbi)
-{
-	return rbi->ring_buffer->pending_send_sz;
-}
-
 /*
  * Request Offer -- no parameters, SynIC message contains the partition ID
  * Set Snoop -- no parameters, SynIC message contains the partition ID
@@ -1092,16 +1086,6 @@ static inline void set_channel_pending_send_size(struct vmbus_channel *c,
 	c->outbound.ring_buffer->pending_send_sz = size;
 }
 
-static inline void set_low_latency_mode(struct vmbus_channel *c)
-{
-	c->low_latency = true;
-}
-
-static inline void clear_low_latency_mode(struct vmbus_channel *c)
-{
-	c->low_latency = false;
-}
-
 void vmbus_onmessage(struct vmbus_channel_message_header *hdr);
 
 int vmbus_request_offers(void);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] hv: Remove unused inline functions in hyperv.h
  2021-07-21 21:41 [PATCH] hv: Remove unused inline functions in hyperv.h Sonia Sharma
@ 2021-07-22  5:35 ` Michael Kelley
  2021-07-22 10:16   ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2021-07-22  5:35 UTC (permalink / raw)
  To: Sonia Sharma, KY Srinivasan, Haiyang Zhang, Stephen Hemminger,
	Wei Liu, Dexuan Cui, linux-hyperv, linux-kernel, Sonia Sharma

From: Sonia Sharma <sosha@linux.microsoft.com> Sent: Wednesday, July 21, 2021 2:41 PM
> 
> There are some unused inline functions in hyperv header file.
> Remove those unused functions.
> 
> Signed-off-by: Sonia Sharma <sonia.sharma@microsoft.com>
> ---
>  include/linux/hyperv.h | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index 2e859d2..ddc8713 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -538,12 +538,6 @@ struct vmbus_channel_rescind_offer {
>  	u32 child_relid;
>  } __packed;
> 
> -static inline u32
> -hv_ringbuffer_pending_size(const struct hv_ring_buffer_info *rbi)
> -{
> -	return rbi->ring_buffer->pending_send_sz;
> -}
> -
>  /*
>   * Request Offer -- no parameters, SynIC message contains the partition ID
>   * Set Snoop -- no parameters, SynIC message contains the partition ID
> @@ -1092,16 +1086,6 @@ static inline void set_channel_pending_send_size(struct vmbus_channel *c,
>  	c->outbound.ring_buffer->pending_send_sz = size;
>  }
> 
> -static inline void set_low_latency_mode(struct vmbus_channel *c)
> -{
> -	c->low_latency = true;
> -}
> -
> -static inline void clear_low_latency_mode(struct vmbus_channel *c)
> -{
> -	c->low_latency = false;
> -}
> -
>  void vmbus_onmessage(struct vmbus_channel_message_header *hdr);
> 
>  int vmbus_request_offers(void);
> --
> 1.8.3.1

Reviewed-by: Michael Kelley <mikelley@microsoft.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hv: Remove unused inline functions in hyperv.h
  2021-07-22  5:35 ` Michael Kelley
@ 2021-07-22 10:16   ` Wei Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2021-07-22 10:16 UTC (permalink / raw)
  To: Michael Kelley
  Cc: Sonia Sharma, KY Srinivasan, Haiyang Zhang, Stephen Hemminger,
	Wei Liu, Dexuan Cui, linux-hyperv, linux-kernel, Sonia Sharma

On Thu, Jul 22, 2021 at 05:35:31AM +0000, Michael Kelley wrote:
> From: Sonia Sharma <sosha@linux.microsoft.com> Sent: Wednesday, July 21, 2021 2:41 PM
> > 
> > There are some unused inline functions in hyperv header file.
> > Remove those unused functions.
> > 
> > Signed-off-by: Sonia Sharma <sonia.sharma@microsoft.com>
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> 

Applied to hyperv-next with minor adjustments to commit message.

Wei.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-22 10:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 21:41 [PATCH] hv: Remove unused inline functions in hyperv.h Sonia Sharma
2021-07-22  5:35 ` Michael Kelley
2021-07-22 10:16   ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).