From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@gmail.com, deller@gmx.de, javierm@redhat.com
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-hyperv@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 13/18] fbdev/offb: Do not use struct fb_info.apertures
Date: Mon, 19 Dec 2022 17:05:11 +0100 [thread overview]
Message-ID: <20221219160516.23436-14-tzimmermann@suse.de> (raw)
In-Reply-To: <20221219160516.23436-1-tzimmermann@suse.de>
Acquire ownership of the firmware scanout buffer by calling Linux'
aperture helpers. Remove the use of struct fb_info.apertures and do
not set FBINFO_MISC_FIRMWARE; both of which previously configured
buffer ownership.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/fbdev/offb.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index a298adcee2d9..f7ad6bc9d02d 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -12,6 +12,7 @@
* more details.
*/
+#include <linux/aperture.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/errno.h>
@@ -54,6 +55,8 @@ struct offb_par {
int cmap_type;
int blanked;
u32 pseudo_palette[16];
+ resource_size_t base;
+ resource_size_t size;
};
#ifdef CONFIG_PPC32
@@ -279,9 +282,11 @@ static int offb_set_par(struct fb_info *info)
static void offb_destroy(struct fb_info *info)
{
+ struct offb_par *par = info->par;
+
if (info->screen_base)
iounmap(info->screen_base);
- release_mem_region(info->apertures->ranges[0].base, info->apertures->ranges[0].size);
+ release_mem_region(par->base, par->size);
fb_dealloc_cmap(&info->cmap);
framebuffer_release(info);
}
@@ -503,20 +508,18 @@ static void offb_init_fb(struct platform_device *parent, const char *name,
var->sync = 0;
var->vmode = FB_VMODE_NONINTERLACED;
- /* set offb aperture size for generic probing */
- info->apertures = alloc_apertures(1);
- if (!info->apertures)
- goto out_aper;
- info->apertures->ranges[0].base = address;
- info->apertures->ranges[0].size = fix->smem_len;
+ par->base = address;
+ par->size = fix->smem_len;
info->fbops = &offb_ops;
info->screen_base = ioremap(address, fix->smem_len);
info->pseudo_palette = par->pseudo_palette;
- info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE | foreign_endian;
+ info->flags = FBINFO_DEFAULT | foreign_endian;
fb_alloc_cmap(&info->cmap, 256, 0);
+ if (devm_aperture_acquire_for_platform_device(parent, par->base, par->size) < 0)
+ goto out_err;
if (register_framebuffer(info) < 0)
goto out_err;
@@ -526,7 +529,6 @@ static void offb_init_fb(struct platform_device *parent, const char *name,
out_err:
fb_dealloc_cmap(&info->cmap);
iounmap(info->screen_base);
-out_aper:
iounmap(par->cmap_adr);
par->cmap_adr = NULL;
framebuffer_release(info);
--
2.39.0
next prev parent reply other threads:[~2022-12-19 16:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 16:04 [PATCH 00/18] drm,fbdev: Remove apertures structure and FBINFO_MISC_FIRMWARE Thomas Zimmermann
2022-12-19 16:04 ` [PATCH 01/18] fbcon: Remove trailing whitespaces Thomas Zimmermann
2022-12-20 9:10 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 02/18] Revert "fbcon: don't lose the console font across generic->chip driver switch" Thomas Zimmermann
2022-12-20 9:17 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 03/18] drm/gma500: Do not set struct fb_info.apertures Thomas Zimmermann
2022-12-20 9:18 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 04/18] drm/i915: " Thomas Zimmermann
2022-12-20 9:19 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 05/18] drm/radeon: " Thomas Zimmermann
2022-12-20 9:19 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 06/18] drm/fb-helper: Do not allocate unused apertures structure Thomas Zimmermann
2022-12-20 9:22 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 07/18] fbdev/clps711x-fb: Do not set struct fb_info.apertures Thomas Zimmermann
2022-12-20 9:24 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 08/18] fbdev/hyperv-fb: " Thomas Zimmermann
2022-12-20 9:24 ` Javier Martinez Canillas
2022-12-29 15:57 ` Michael Kelley (LINUX)
2022-12-19 16:05 ` [PATCH 09/18] vfio-mdev/mdpy-fb: " Thomas Zimmermann
2022-12-20 9:32 ` Javier Martinez Canillas
2023-01-03 13:54 ` Thomas Zimmermann
2022-12-19 16:05 ` [PATCH 10/18] fbdev/efifb: Add struct efifb_par for driver data Thomas Zimmermann
2022-12-20 9:33 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 11/18] fbdev/efifb: Do not use struct fb_info.apertures Thomas Zimmermann
2022-12-20 9:35 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 12/18] fbdev/offb: Allocate struct offb_par with framebuffer_alloc() Thomas Zimmermann
2022-12-20 9:37 ` Javier Martinez Canillas
2022-12-19 16:05 ` Thomas Zimmermann [this message]
2022-12-20 9:38 ` [PATCH 13/18] fbdev/offb: Do not use struct fb_info.apertures Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 14/18] fbdev/simplefb: " Thomas Zimmermann
2022-12-20 9:40 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 15/18] fbdev/vesafb: Remove trailing whitespaces Thomas Zimmermann
2022-12-20 9:40 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 16/18] fbdev/vesafb: Do not use struct fb_info.apertures Thomas Zimmermann
2022-12-20 9:43 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 17/18] fbdev/vga16fb: " Thomas Zimmermann
2022-12-20 9:44 ` Javier Martinez Canillas
2022-12-19 16:05 ` [PATCH 18/18] drm/fbdev: Remove aperture handling and FBINFO_MISC_FIRMWARE Thomas Zimmermann
2022-12-20 9:46 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219160516.23436-14-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).