From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jon Doron <arilou@gmail.com>,
kvm@vger.kernel.org, linux-hyperv@vger.kernel.org
Subject: Re: [PATCH v11 4/7] x86/kvm/hyper-v: Add support for synthetic debugger capability
Date: Fri, 29 May 2020 14:08:31 +0200 [thread overview]
Message-ID: <87ftbjhrk0.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <12df4348-3dc1-a4cc-aa41-4492cd42dcc8@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 24/04/20 13:37, Jon Doron wrote:
>> +static int syndbg_get_msr(struct kvm_vcpu *vcpu, u32 msr, u64 *pdata, bool host)
>> +{
>> + struct kvm_hv_syndbg *syndbg = vcpu_to_hv_syndbg(vcpu);
>> +
>> + if (!syndbg->active && !host)
>> + return 1;
>> +
>
> One small thing: is the ENABLE_CAP and active field needed? Can you
> just check if the guest has the syndbg CPUID bits set?
>
Yes, we can probably get away with a static capability (so userspace
knows that the interface is supported and CPUID bit can be set) and
check guest_cpuid_has() here but we don't have Hyper-V feature leaves
exposed as X86_FEATURE_* (yet). It is probably possible to implement an
interim solution by open coding the check with kvm_find_cpuid_entry() or
something like that.
--
Vitaly
next prev parent reply other threads:[~2020-05-29 12:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 11:37 [PATCH v11 0/7] x86/kvm/hyper-v: add support for synthetic debugger Jon Doron
2020-04-24 11:37 ` [PATCH v11 1/7] x86/kvm/hyper-v: Explicitly align hcall param for kvm_hyperv_exit Jon Doron
2020-05-13 8:42 ` Roman Kagan
2020-04-24 11:37 ` [PATCH v11 2/7] x86/kvm/hyper-v: Simplify addition for custom cpuid leafs Jon Doron
2020-05-13 9:24 ` Roman Kagan
2020-05-13 12:49 ` Jon Doron
2020-05-29 11:13 ` Paolo Bonzini
2020-04-24 11:37 ` [PATCH v11 3/7] x86/hyper-v: Add synthetic debugger definitions Jon Doron
2020-04-24 11:37 ` [PATCH v11 4/7] x86/kvm/hyper-v: Add support for synthetic debugger capability Jon Doron
2020-05-29 10:46 ` Paolo Bonzini
2020-05-29 12:08 ` Vitaly Kuznetsov [this message]
2020-05-29 12:17 ` Paolo Bonzini
2020-04-24 11:37 ` [PATCH v11 5/7] x86/kvm/hyper-v: enable hypercalls without hypercall page with syndbg Jon Doron
2020-05-13 9:57 ` Roman Kagan
2020-05-13 12:37 ` Jon Doron
2020-05-29 10:48 ` Paolo Bonzini
2020-04-24 11:37 ` [PATCH v11 6/7] x86/kvm/hyper-v: Add support for synthetic debugger via hypercalls Jon Doron
2020-05-12 15:33 ` Roman Kagan
2020-05-13 12:39 ` Jon Doron
2020-04-24 11:37 ` [PATCH v11 7/7] KVM: selftests: update hyperv_cpuid with SynDBG tests Jon Doron
2020-05-07 3:01 ` [PATCH v11 0/7] x86/kvm/hyper-v: add support for synthetic debugger Jon Doron
2020-05-07 7:57 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftbjhrk0.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=arilou@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).