From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Andrea Parri <parri.andrea@gmail.com>, Dexuan Cui <decui@microsoft.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv\@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Sasha Levin <sashal@kernel.org>,
Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH 0/2] Drivers: hv: vmbus: Miscellaneous improvements
Date: Tue, 08 Oct 2019 21:47:18 +0200 [thread overview]
Message-ID: <87imozyq7t.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20191008150847.GA15276@andrea>
Andrea Parri <parri.andrea@gmail.com> writes:
> On Mon, Oct 07, 2019 at 05:41:10PM +0000, Dexuan Cui wrote:
>> > From: linux-hyperv-owner@vger.kernel.org
>> > <linux-hyperv-owner@vger.kernel.org> On Behalf Of Andrea Parri
>> > Sent: Monday, October 7, 2019 9:31 AM
>> >
>> > Hi all,
>> >
>> > The patchset:
>> >
>> > - simplifies/refactors the VMBus negotiation code by introducing
>> > the table of VMBus protocol versions (patch 1/2),
>> >
>> > - enables VMBus protocol versions 5.1 and 5.2 (patch 2/2).
>> >
>> > Thanks,
>> > Andrea
>> >
>> > Andrea Parri (2):
>> > Drivers: hv: vmbus: Introduce table of VMBus protocol versions
>> > Drivers: hv: vmbus: Enable VMBus protocol versions 5.1 and 5.2
>>
>> Should we add a module parameter to allow the user to specify a lower
>> protocol version, when the VM runs on the latest host?
>>
>> This can be useful for testing and debugging purpose: the variable
>> "vmbus_proto_version" is referenced by the vmbus driver itself and
>> some VSC drivers: if we always use the latest available proto version,
>> some code paths can not be tested on the latest hosts.
>
> The idea is appealing to me (altough I made no attempt to implement/test
> it yet). What do others think about this? Maybe can be considered as a
> follow-up patch/work to this series?
IMO such debug option makes sense, it shouldn be a simple patch so you
may want to squeeze it in this series as it will definitely have code
dependencies.
--
Vitaly
prev parent reply other threads:[~2019-10-08 19:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 16:31 [PATCH 0/2] Drivers: hv: vmbus: Miscellaneous improvements Andrea Parri
2019-10-07 16:31 ` [PATCH 1/2] Drivers: hv: vmbus: Introduce table of VMBus protocol versions Andrea Parri
2019-10-07 17:14 ` Vitaly Kuznetsov
2019-10-08 12:41 ` Andrea Parri
2019-10-08 12:44 ` Andrea Parri
2019-10-08 13:00 ` Vitaly Kuznetsov
2019-10-08 22:41 ` Dexuan Cui
2019-10-09 9:54 ` Andrea Parri
2019-10-07 17:25 ` Dexuan Cui
2019-10-08 12:42 ` Andrea Parri
2019-10-07 16:31 ` [PATCH 2/2] Drivers: hv: vmbus: Enable VMBus protocol versions 5.1 and 5.2 Andrea Parri
2019-10-07 17:41 ` [PATCH 0/2] Drivers: hv: vmbus: Miscellaneous improvements Dexuan Cui
2019-10-08 15:08 ` Andrea Parri
2019-10-08 19:47 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imozyq7t.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=parri.andrea@gmail.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).