From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B9BDC433E1 for ; Wed, 26 Aug 2020 21:33:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2D452087C for ; Wed, 26 Aug 2020 21:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598477616; bh=YW+rIBasGHh+otBTvN1XkgP5e9k6NldvJXC4gJyKR58=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=MKpa9tA1JQU8ReC9diAMAaEBlgL7yY7XLaDLOnL2ckOpJvO3CXN1AaEa2SJapyfl+ 94GZxS+hLpKTdjkiFhJLBfQw5VAfxS+MYxtbNByX9jLUK6Y7ZWXc8QWz6mSxnerGcs en+dDs01M8wzKsLEN7Zi02bHnVeaUy2yKJGkZ9ZY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgHZVdg (ORCPT ); Wed, 26 Aug 2020 17:33:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:51400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726765AbgHZVdg (ORCPT ); Wed, 26 Aug 2020 17:33:36 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 619A820737; Wed, 26 Aug 2020 21:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598477615; bh=YW+rIBasGHh+otBTvN1XkgP5e9k6NldvJXC4gJyKR58=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ze75GSnVu1xfS6xKQa3PMkeLwc9wY7nMYazNki7oeT0LUlePw0Jm59U12hcPyfRAt tyxRrFUh8E/er/Ben6cRUvuYwXkO+DOUu9MHR0AOVwliboMYJNmNpYWzZMp5WyvLL0 KrNgTCJoAN8jXt3bFS1kKpKI0lYGg8z85cSB+20Y= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kB32z-006yv7-Gz; Wed, 26 Aug 2020 22:33:34 +0100 Date: Wed, 26 Aug 2020 22:33:31 +0100 Message-ID: <87y2m1149g.wl-maz@kernel.org> From: Marc Zyngier To: Thomas Gleixner Cc: LKML , x86@kernel.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-hyperv@vger.kernel.org, Haiyang Zhang , Jon Derrick , Lu Baolu , Wei Liu , "K. Y. Srinivasan" , Stephen Hemminger , Steve Wahl , Dimitri Sivanich , Russ Anderson , linux-pci@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Greg Kroah-Hartman , "Rafael J. Wysocki" , Megha Dey , Jason Gunthorpe , Dave Jiang , Alex Williamson , Jacob Pan , Baolu Lu , Kevin Tian , Dan Williams Subject: Re: [patch V2 29/46] irqdomain/msi: Allow to override msi_domain_alloc/free_irqs() In-Reply-To: <87zh6htcit.fsf@nanos.tec.linutronix.de> References: <20200826111628.794979401@linutronix.de> <20200826112333.526797548@linutronix.de> <87blix2pna.wl-maz@kernel.org> <87zh6htcit.fsf@nanos.tec.linutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, x86@kernel.org, joro@8bytes.org, iommu@lists.linux-foundation.org, linux-hyperv@vger.kernel.org, haiyangz@microsoft.com, jonathan.derrick@intel.com, baolu.lu@linux.intel.com, wei.liu@kernel.org, kys@microsoft.com, sthemmin@microsoft.com, steve.wahl@hpe.com, sivanich@hpe.com, rja@hpe.com, linux-pci@vger.kernel.org, bhelgaas@google.com, lorenzo.pieralisi@arm.com, konrad.wilk@oracle.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, sstabellini@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, megha.dey@intel.com, jgg@mellanox.com, dave.jiang@intel.com, alex.williamson@redhat.com, jacob.jun.pan@intel.com, baolu.lu@intel.com, kevin.tian@intel.com, dan.j.williams@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, 26 Aug 2020 20:47:38 +0100, Thomas Gleixner wrote: > > On Wed, Aug 26 2020 at 20:06, Marc Zyngier wrote: > > On Wed, 26 Aug 2020 12:16:57 +0100, > > Thomas Gleixner wrote: > >> /** > >> - * msi_domain_free_irqs - Free interrupts from a MSI interrupt @domain associated tp @dev > >> - * @domain: The domain to managing the interrupts > >> + * msi_domain_alloc_irqs - Allocate interrupts from a MSI interrupt domain > >> + * @domain: The domain to allocate from > >> * @dev: Pointer to device struct of the device for which the interrupts > >> - * are free > >> + * are allocated > >> + * @nvec: The number of interrupts to allocate > >> + * > >> + * Returns 0 on success or an error code. > >> */ > >> -void msi_domain_free_irqs(struct irq_domain *domain, struct device *dev) > >> +int msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev, > >> + int nvec) > >> +{ > >> + struct msi_domain_info *info = domain->host_data; > >> + struct msi_domain_ops *ops = info->ops; > > > > Rework leftovers, I imagine. > > Hmm, no. How would it call ops->domain_alloc_irqs() without getting the > ops. I know, that the diff is horrible, but don't blame me for it. diff > sucks at times. I can't read. Time to put the laptop away! Thanks, M. -- Without deviation from the norm, progress is not possible.