From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F077C41621 for ; Tue, 24 Mar 2020 13:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC85220775 for ; Tue, 24 Mar 2020 13:28:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CEn+c7bf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729557AbgCXN2g (ORCPT ); Tue, 24 Mar 2020 09:28:36 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:56858 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729770AbgCXN2e (ORCPT ); Tue, 24 Mar 2020 09:28:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585056513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1Nbgg36XeJ0SkoOvyM0axieUMOjkCcVecsvZVfglBfA=; b=CEn+c7bfUaC+3T8Z1qmCq0MJm2bMtfh+QdCWsch4TItnuvN2SQeSDETCq12Zm7Upm2ONQ2 3t/1zWDo1MYNYj6kaEVUvFLAIhb1f1hVf/Gf5YQiBcDbjDiYFZQ1UD9uVdBeXT6rcgpspK DJCFlpxTrJaJ0SxtVlNqowp+Q24Ojqs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-I8D2DQ3kPnKL3pdId-jubg-1; Tue, 24 Mar 2020 09:28:31 -0400 X-MC-Unique: I8D2DQ3kPnKL3pdId-jubg-1 Received: by mail-wm1-f72.google.com with SMTP id h203so1235330wme.2 for ; Tue, 24 Mar 2020 06:28:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=1Nbgg36XeJ0SkoOvyM0axieUMOjkCcVecsvZVfglBfA=; b=ZVDAZMN2jsl/OtFdbOAbBDcr+K/nMPUYQtJHkfi3rTwRUhPccL/O0HFusP1JQZ5AUo micPIV3bV/XgNqhF9T9ESLP0/Y5ZSyx783DjBD1XRdk5JyPt65CiRsYV6+Cp3L+qgNAX s2DS2OP2SAWm6lX+QJB7sQzrXUpF1Ye/S81oPndGdN2cnrtOWt167pk9D/N0/3Oi9sVH ZzJx7uA369JCXs3RsFB/pYHL0hSriOdUz3tPIGxf+HH401rW77C7PIkkP9i+FQRaY69A oofm99tyVAQHJcjBkSr9WrCIS/OfO/otmXDNC6wJWkNBdzDV7XBFbR2qc5qxaqyV4IB9 YSqA== X-Gm-Message-State: ANhLgQ0XHcqUD89MNjk3A4ty5y5IlEBJ/WOcgBTQ2XRPdBLzMhb52hO4 v2B2fEmvjNZko/LnI4cEgigSsDQIciNwB3Nw53AHdkT+NQOjcp3rReWmef1yNzjmPzAcAiSrqhY yDqTzaLUd1OQVkmcjt1RvGvd7 X-Received: by 2002:a1c:c257:: with SMTP id s84mr5612652wmf.0.1585056510761; Tue, 24 Mar 2020 06:28:30 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu+pmPGSpmmN/mSKsnMjvbTacJnshjSpGN9O/2Pk17BNy+smzoup721KMAL6lt6m/HClETc6g== X-Received: by 2002:a1c:c257:: with SMTP id s84mr5612634wmf.0.1585056510458; Tue, 24 Mar 2020 06:28:30 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id q8sm29593589wrc.8.2020.03.24.06.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 06:28:29 -0700 (PDT) From: Vitaly Kuznetsov To: Jon Doron , kvm@vger.kernel.org, linux-hyperv@vger.kernel.org Cc: Jon Doron Subject: Re: [PATCH v10 5/7] x86/kvm/hyper-v: enable hypercalls without hypercall page with syndbg In-Reply-To: <20200324074341.1770081-6-arilou@gmail.com> References: <20200324074341.1770081-1-arilou@gmail.com> <20200324074341.1770081-6-arilou@gmail.com> Date: Tue, 24 Mar 2020 14:28:28 +0100 Message-ID: <87zhc57ugz.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org Jon Doron writes: > Microsoft's kdvm.dll dbgtransport module does not respect the hypercall > page and simply identifies the CPU being used (AMD/Intel) and according > to it simply makes hypercalls with the relevant instruction > (vmmcall/vmcall respectively). > > The relevant function in kdvm is KdHvConnectHypervisor which first checks > if the hypercall page has been enabled via HV_X64_MSR_HYPERCALL_ENABLE, > and in case it was not it simply sets the HV_X64_MSR_GUEST_OS_ID to > 0x1000101010001 which means: > build_number = 0x0001 > service_version = 0x01 > minor_version = 0x01 > major_version = 0x01 > os_id = 0x00 (Undefined) > vendor_id = 1 (Microsoft) > os_type = 0 (A value of 0 indicates a proprietary, closed source OS) > > and starts issuing the hypercall without setting the hypercall page. > > To resolve this issue simply enable hypercalls also if the guest_os_id > is not 0 and the syndbg feature is enabled. > > Signed-off-by: Jon Doron > --- > arch/x86/kvm/hyperv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index befe5b3b9e20..59c6eadb7eca 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -1650,7 +1650,10 @@ static u64 kvm_hv_send_ipi(struct kvm_vcpu *current_vcpu, u64 ingpa, u64 outgpa, > > bool kvm_hv_hypercall_enabled(struct kvm *kvm) > { > - return READ_ONCE(kvm->arch.hyperv.hv_hypercall) & HV_X64_MSR_HYPERCALL_ENABLE; > + struct kvm_hv *hv = &kvm->arch.hyperv; > + > + return READ_ONCE(hv->hv_hypercall) & HV_X64_MSR_HYPERCALL_ENABLE || > + (hv->hv_syndbg.active && READ_ONCE(hv->hv_guest_os_id) != 0); > } > > static void kvm_hv_hypercall_set_result(struct kvm_vcpu *vcpu, u64 result) Reviewed-by: Vitaly Kuznetsov -- Vitaly