From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04AEC4363D for ; Fri, 25 Sep 2020 08:39:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78E8521775 for ; Fri, 25 Sep 2020 08:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbgIYIjh (ORCPT ); Fri, 25 Sep 2020 04:39:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:46898 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727395AbgIYIjg (ORCPT ); Fri, 25 Sep 2020 04:39:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 511CDB29D; Fri, 25 Sep 2020 08:39:35 +0000 (UTC) Subject: Re: [PATCH RFC 3/4] mm/page_alloc: always move pages to the tail of the freelist in unset_migratetype_isolate() To: David Hildenbrand , Wei Yang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Andrew Morton , Alexander Duyck , Mel Gorman , Michal Hocko , Dave Hansen , Oscar Salvador , Mike Rapoport , Scott Cheloha , Michael Ellerman References: <20200916183411.64756-1-david@redhat.com> <20200916183411.64756-4-david@redhat.com> <9c6cc094-b02a-ac6c-e1ca-370ce7257881@suse.cz> <20200925024552.GA13540@L-31X9LVDL-1304.local> From: Vlastimil Babka Message-ID: <8e9a4427-3c95-22f5-1e0b-5e3c9fa86592@suse.cz> Date: Fri, 25 Sep 2020 10:39:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On 9/25/20 10:05 AM, David Hildenbrand wrote: >>>> static inline void del_page_from_free_list(struct page *page, struct zone *zone, >>>> unsigned int order) >>>> { >>>> @@ -2323,7 +2332,7 @@ static inline struct page *__rmqueue_cma_fallback(struct zone *zone, >>>> */ >>>> static int move_freepages(struct zone *zone, >>>> struct page *start_page, struct page *end_page, >>>> - int migratetype, int *num_movable) >>>> + int migratetype, int *num_movable, bool to_tail) >>>> { >>>> struct page *page; >>>> unsigned int order; >>>> @@ -2354,7 +2363,10 @@ static int move_freepages(struct zone *zone, >>>> VM_BUG_ON_PAGE(page_zone(page) != zone, page); >>>> >>>> order = page_order(page); >>>> - move_to_free_list(page, zone, order, migratetype); >>>> + if (to_tail) >>>> + move_to_free_list_tail(page, zone, order, migratetype); >>>> + else >>>> + move_to_free_list(page, zone, order, migratetype); >>>> page += 1 << order; >>>> pages_moved += 1 << order; >>>> } >>>> @@ -2362,8 +2374,9 @@ static int move_freepages(struct zone *zone, >>>> return pages_moved; >>>> } >>>> >>>> -int move_freepages_block(struct zone *zone, struct page *page, >>>> - int migratetype, int *num_movable) >>>> +static int __move_freepages_block(struct zone *zone, struct page *page, >>>> + int migratetype, int *num_movable, >>>> + bool to_tail) >>>> { >>>> unsigned long start_pfn, end_pfn; >>>> struct page *start_page, *end_page; >>>> @@ -2384,7 +2397,20 @@ int move_freepages_block(struct zone *zone, struct page *page, >>>> return 0; >>>> >>>> return move_freepages(zone, start_page, end_page, migratetype, >>>> - num_movable); >>>> + num_movable, to_tail); >>>> +} >>>> + >>>> +int move_freepages_block(struct zone *zone, struct page *page, >>>> + int migratetype, int *num_movable) >>>> +{ >>>> + return __move_freepages_block(zone, page, migratetype, num_movable, >>>> + false); >>>> +} >>>> + >>>> +int move_freepages_block_tail(struct zone *zone, struct page *page, >>>> + int migratetype) >>>> +{ >>>> + return __move_freepages_block(zone, page, migratetype, NULL, true); >>>> } >>> >>> Likewise, just 5 callers of move_freepages_block(), all in the files you're >>> already changing, so no need for this wrappers IMHO. > > As long as we don't want to move the implementation to the header, we'll > need it for the constant propagation to work at compile time (we don't > really have link-time optimizations). Or am I missing something? I guess move_freepages_block() is not exactly fast path, so we could do without it. > Thanks! >