From: Tianyu Lan <ltykernel@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, joro@8bytes.org, will@kernel.org,
davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, arnd@arndb.de,
m.szyprowski@samsung.com, robin.murphy@arm.com,
kirill.shutemov@linux.intel.com, akpm@linux-foundation.org,
rppt@kernel.org, Tianyu.Lan@microsoft.com,
thomas.lendacky@amd.com, ardb@kernel.org, robh@kernel.org,
nramas@linux.microsoft.com, pgonda@google.com,
martin.b.radev@gmail.com, david@redhat.com,
krish.sadhukhan@oracle.com, saravanand@fb.com,
xen-devel@lists.xenproject.org, keescook@chromium.org,
rientjes@google.com, hannes@cmpxchg.org,
michael.h.kelley@microsoft.com, iommu@lists.linux-foundation.org,
linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
netdev@vger.kernel.org, vkuznets@redhat.com,
brijesh.singh@amd.com, anparri@microsoft.com
Subject: Re: [Resend RFC PATCH V4 09/13] x86/Swiotlb/HV: Add Swiotlb bounce buffer remap function for HV IVM
Date: Wed, 21 Jul 2021 18:28:48 +0800 [thread overview]
Message-ID: <8f1a285d-4b67-8041-d326-af565b2756c0@gmail.com> (raw)
In-Reply-To: <20210720135437.GA13554@lst.de>
Thanks for review.
On 7/20/2021 9:54 PM, Christoph Hellwig wrote:
>
> Please split the swiotlb changes into a separate patch from the
> consumer.
OK. Will update.
>
>> }
>> +
>> +/*
>> + * hv_map_memory - map memory to extra space in the AMD SEV-SNP Isolation VM.
>> + */
>> +unsigned long hv_map_memory(unsigned long addr, unsigned long size)
>> +{
>> + unsigned long *pfns = kcalloc(size / HV_HYP_PAGE_SIZE,
>> + sizeof(unsigned long),
>> + GFP_KERNEL);
>> + unsigned long vaddr;
>> + int i;
>> +
>> + if (!pfns)
>> + return (unsigned long)NULL;
>> +
>> + for (i = 0; i < size / HV_HYP_PAGE_SIZE; i++)
>> + pfns[i] = virt_to_hvpfn((void *)addr + i * HV_HYP_PAGE_SIZE) +
>> + (ms_hyperv.shared_gpa_boundary >> HV_HYP_PAGE_SHIFT);
>> +
>> + vaddr = (unsigned long)vmap_pfn(pfns, size / HV_HYP_PAGE_SIZE,
>> + PAGE_KERNEL_IO);
>> + kfree(pfns);
>> +
>> + return vaddr;
>
> This seems to miss a 'select VMAP_PFN'.
VMAP_PFN has been selected in the previous patch "RFC PATCH V4 08/13]
HV/Vmbus: Initialize VMbus ring buffer for Isolation VM"
> But more importantly I don't
> think this actually works. Various DMA APIs do expect a struct page
> backing, so how is this going to work with say dma_mmap_attrs or
> dma_get_sgtable_attrs?
dma_mmap_attrs() and dma_get_sgtable_attrs() get input virtual address
belonging to backing memory with struct page and returns bounce buffer
dma physical address which is below shared_gpa_boundary(vTOM) and passed
to Hyper-V via vmbus protocol.
The new map virtual address is only to access bounce buffer in swiotlb
code and will not be used other places. It's stored in the mem->vstart.
So the new API set_memory_decrypted_map() in this series is only called
in the swiotlb code. Other platforms may replace set_memory_decrypted()
with set_memory_decrypted_map() as requested.
>
>> +static unsigned long __map_memory(unsigned long addr, unsigned long size)
>> +{
>> + if (hv_is_isolation_supported())
>> + return hv_map_memory(addr, size);
>> +
>> + return addr;
>> +}
>> +
>> +static void __unmap_memory(unsigned long addr)
>> +{
>> + if (hv_is_isolation_supported())
>> + hv_unmap_memory(addr);
>> +}
>> +
>> +unsigned long set_memory_decrypted_map(unsigned long addr, unsigned long size)
>> +{
>> + if (__set_memory_enc_dec(addr, size / PAGE_SIZE, false))
>> + return (unsigned long)NULL;
>> +
>> + return __map_memory(addr, size);
>> +}
>> +
>> +int set_memory_encrypted_unmap(unsigned long addr, unsigned long size)
>> +{
>> + __unmap_memory(addr);
>> + return __set_memory_enc_dec(addr, size / PAGE_SIZE, true);
>> +}
>
> Why this obsfucation into all kinds of strange helpers? Also I think
> we want an ops vectors (or alternative calls) instead of the random
> if checks here.
Yes, agree and will add ops for different platforms to map/unmap memory.
>
>> + * @vstart: The virtual start address of the swiotlb memory pool. The swiotlb
>> + * memory pool may be remapped in the memory encrypted case and store
>
> Normall we'd call this vaddr or cpu_addr.
OK. Will update.
>
>> - set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
>> - memset(vaddr, 0, bytes);
>> + mem->vstart = (void *)set_memory_decrypted_map((unsigned long)vaddr, bytes);
>
> Please always pass kernel virtual addresses as pointers.
>
> And I think these APIs might need better names, e.g.
>
> arch_dma_map_decrypted and arch_dma_unmap_decrypted.
>
> Also these will need fallback versions for non-x86 architectures that
> currently use memory encryption.
Sure. Will update in the next version.
next prev parent reply other threads:[~2021-07-21 11:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 15:46 [Resend RFC PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 01/13] x86/HV: Initialize GHCB page in Isolation VM Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 02/13] x86/HV: Initialize shared memory boundary in the " Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 03/13] x86/HV: Add new hvcall guest address host visibility support Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 04/13] HV: Mark vmbus ring buffer visible to host in Isolation VM Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 05/13] HV: Add Write/Read MSR registers via ghcb page Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 06/13] HV: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 07/13] HV/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 08/13] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 09/13] x86/Swiotlb/HV: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan
2021-07-20 10:42 ` Tianyu Lan
2021-07-20 13:54 ` Christoph Hellwig
2021-07-21 10:28 ` Tianyu Lan [this message]
2021-07-21 14:33 ` Christoph Hellwig
2021-07-21 15:11 ` Tianyu Lan
2021-08-13 16:43 ` Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 10/13] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 11/13] HV/Netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 12/13] HV/Storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
2021-07-07 15:46 ` [Resend RFC PATCH V4 13/13] x86/HV: Not set memory decrypted/encrypted during kexec alloc/free page in IVM Tianyu Lan
2021-07-07 16:14 ` Dave Hansen
2021-07-08 13:54 ` Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f1a285d-4b67-8041-d326-af565b2756c0@gmail.com \
--to=ltykernel@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=anparri@microsoft.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jejb@linux.ibm.com \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.b.radev@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=michael.h.kelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=saravanand@fb.com \
--cc=sstabellini@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).