RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

[Haiyang Zhang <haiyangz@microsoft.com>]

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Monday, April 12, 2021 8:16 AM
> To: Dexuan Cui <decui@microsoft.com>
> Cc: davem@davemloft.net; kuba@kernel.org; KY Srinivasan
> <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Stephen
> Hemminger <sthemmin@microsoft.com>; wei.liu@kernel.org; Wei Liu
> <liuwe@microsoft.com>; netdev@vger.kernel.org; leon@kernel.org;
> bernd@petrovitsch.priv.at; rdunlap@infradead.org; Shachar Raindel
> <shacharr@microsoft.com>; linux-kernel@vger.kernel.org; linux-
> hyperv@vger.kernel.org
> Subject: Re: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure
> Network Adapter (MANA)
> 
> > +static inline bool is_gdma_msg(const void *req) {
> > +	struct gdma_req_hdr *hdr = (struct gdma_req_hdr *)req;
> > +
> > +	if (hdr->req.hdr_type == GDMA_STANDARD_HEADER_TYPE &&
> > +	    hdr->resp.hdr_type == GDMA_STANDARD_HEADER_TYPE &&
> > +	    hdr->req.msg_size >= sizeof(struct gdma_req_hdr) &&
> > +	    hdr->resp.msg_size >= sizeof(struct gdma_resp_hdr) &&
> > +	    hdr->req.msg_type != 0 && hdr->resp.msg_type != 0)
> > +		return true;
> > +
> > +	return false;
> > +}
> > +
> > +static inline bool is_gdma_msg_len(const u32 req_len, const u32 resp_len,
> > +				   const void *req)
> > +{
> > +	struct gdma_req_hdr *hdr = (struct gdma_req_hdr *)req;
> > +
> > +	if (req_len >= sizeof(struct gdma_req_hdr) &&
> > +	    resp_len >= sizeof(struct gdma_resp_hdr) &&
> > +	    req_len >= hdr->req.msg_size && resp_len >= hdr->resp.msg_size
> &&
> > +	    is_gdma_msg(req)) {
> > +		return true;
> > +	}
> > +
> > +	return false;
> > +}
> 
> You missed adding the mana_ prefix here. There might be others.
> 
> > +#define CQE_POLLING_BUFFER 512
> > +struct ana_eq {
> > +	struct gdma_queue *eq;
> > +	struct gdma_comp cqe_poll[CQE_POLLING_BUFFER]; };
> 
> > +static int ana_poll(struct napi_struct *napi, int budget) {
> 
> You also have a few cases of ana_, not mana_. There might be others.

We will rename the remaining ana_ to mana_.
Also the driver version to protocol version in your previous comments.

Thanks,
- Haiyang