From: Long Li <longli@microsoft.com>
To: Jiri Slaby <jirislaby@kernel.org>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>,
"linux-fs@vger.kernel.org" <linux-fs@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
Mike Rapoport <rppt@kernel.org>,
Ben Widawsky <ben.widawsky@intel.com>,
Andra Paraschiv <andraprs@amazon.com>,
Siddharth Gupta <sidgup@codeaurora.org>,
Hannes Reinecke <hare@suse.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [Patch v4 2/3] Drivers: hv: add Azure Blob driver
Date: Wed, 21 Jul 2021 16:07:52 +0000 [thread overview]
Message-ID: <BY5PR21MB1506F9C0C510433A4FD0EFEECEE39@BY5PR21MB1506.namprd21.prod.outlook.com> (raw)
In-Reply-To: <5c5dd1e5-2639-b293-b2e0-d7cfd5ca3c0c@kernel.org>
> Subject: Re: [Patch v4 2/3] Drivers: hv: add Azure Blob driver
>
> On 21. 07. 21, 0:12, Long Li wrote:
> >> Subject: Re: [Patch v4 2/3] Drivers: hv: add Azure Blob driver
> >>
> >> On 20. 07. 21, 5:31, longli@linuxonhyperv.com wrote:
> >>> --- /dev/null
> >>> +++ b/include/uapi/misc/hv_azure_blob.h
> >>> @@ -0,0 +1,34 @@
> >>> +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
> >>> +/* Copyright (c) 2021 Microsoft Corporation. */
> >>> +
> >>> +#ifndef _AZ_BLOB_H
> >>> +#define _AZ_BLOB_H
> >>> +
> >>> +#include <linux/kernel.h>
> >>> +#include <linux/uuid.h>
> >>
> >> Quoting from
> >>
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
> >> kernel.org%2Flinux-
> >>
> doc%2FMWHPR21MB159375586D810EC5DCB66AF0D7039%40MWHPR21M
> B1
> >>
> 593.namprd21.prod.outlook.com%2F&data=04%7C01%7Clongli%40micr
> >>
> osoft.com%7C7fdf2d6ed15d4d4122a308d94b6eeed0%7C72f988bf86f141af
> 91
> >>
> ab2d7cd011db47%7C1%7C0%7C637623762292949381%7CUnknown%7CTW
> Fp
> >>
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> >>
> I6Mn0%3D%7C3000&sdata=kv0ZkU1QL6TxlJJZEQEsT7aqLFL9lmP2SStz8k
> >> U5sIs%3D&reserved=0:
> >> =====
> >> Seems like a #include of asm/ioctl.h (or something similar) is needed
> >> so that _IOWR is defined. Also, a #include is needed for __u32,
> >> __aligned_u64, guid_t, etc.
> >> =====
> >
> > The user-space code includes "sys/ioctl.h" for calling into ioctl(). "sys/ioctl.h"
> > includes <linux/ioctl.h>, so it has no problem finding _IOWR.
> >
> > guid_t is defined in <uapi/linux/uuid.h>, included from <linux/uuid.h>
> > (in this file)
> > __u32 and __aligned_u64 are defined in <uapi/linux/types.>, which is
> > included from <linux/kernel.h> (in this file)
>
> No, please don't rely on implicit include chains. Nor that userspace solves the
> includes for you.
Will fix this.
>
> thanks,
> --
> js
> suse labs
next prev parent reply other threads:[~2021-07-21 16:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 3:31 [Patch v4 0/3] Introduce a driver to support host accelerated access to Microsoft Azure Blob longli
2021-07-20 3:31 ` [Patch v4 1/3] Drivers: hv: vmbus: add support to ignore certain PCIE devices longli
2021-07-20 3:31 ` [Patch v4 2/3] Drivers: hv: add Azure Blob driver longli
2021-07-20 5:26 ` Greg Kroah-Hartman
2021-07-20 5:30 ` Greg Kroah-Hartman
2021-07-20 7:34 ` Greg Kroah-Hartman
2021-07-20 19:57 ` Long Li
2021-07-21 5:08 ` Greg Kroah-Hartman
2021-07-20 11:10 ` Jiri Slaby
2021-07-20 22:12 ` Long Li
2021-07-21 4:57 ` Jiri Slaby
2021-07-21 16:07 ` Long Li [this message]
2021-07-20 3:31 ` [Patch v4 3/3] Drivers: hv: Add to maintainer for Hyper-V/Azure drivers longli
2021-07-20 4:37 ` [Patch v4 0/3] Introduce a driver to support host accelerated access to Microsoft Azure Blob Bart Van Assche
2021-07-20 6:01 ` Christoph Hellwig
2021-07-20 7:05 ` Long Li
2021-07-20 15:15 ` Bart Van Assche
2021-07-20 17:33 ` Long Li
2021-07-20 18:16 ` gregkh
2021-07-20 18:52 ` Long Li
2021-07-20 15:54 ` Greg KH
2021-07-20 18:37 ` Long Li
2021-07-21 5:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR21MB1506F9C0C510433A4FD0EFEECEE39@BY5PR21MB1506.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=andraprs@amazon.com \
--cc=ben.widawsky@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=hdegoede@redhat.com \
--cc=jirislaby@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fs@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=luzmaximilian@gmail.com \
--cc=rppt@kernel.org \
--cc=sidgup@codeaurora.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).