From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA2AC33CAA for ; Tue, 21 Jan 2020 09:07:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 892D420882 for ; Tue, 21 Jan 2020 09:07:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K85Bbt3j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728816AbgAUJHT (ORCPT ); Tue, 21 Jan 2020 04:07:19 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:57069 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727969AbgAUJHS (ORCPT ); Tue, 21 Jan 2020 04:07:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579597635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aBt9kA8Q3sfLDPWSB6WPSmED3batQYaL6AuEX7S5BEo=; b=K85Bbt3jACp3vTIlrtG0rQmWv5Pj8PPLRbxYeyT8vTKn9lwxNeXvdQuKUIS02QvIzPBJdt sm/1R2umwLXoXvEaHT5z//rDCVDUJ7GuFbvbb1Ak8ba6xMS2K3WCnWpSqJ+hCpjbN+ufai 7ELFZ30Z9pVqhctG9X+k0r3VN3mydBI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-PUgedhz6P3yskVvpVZxyYg-1; Tue, 21 Jan 2020 04:07:11 -0500 X-MC-Unique: PUgedhz6P3yskVvpVZxyYg-1 Received: by mail-wr1-f72.google.com with SMTP id j4so1025179wrs.13 for ; Tue, 21 Jan 2020 01:07:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aBt9kA8Q3sfLDPWSB6WPSmED3batQYaL6AuEX7S5BEo=; b=kEJHHOW/A7ySQ3AbbU2c8IRV0shjLTnIIUicGNaK1Kob+eL5b3+HBPvL571mFeT+Z8 alEFtPWw0RX4kV8QCanAQsO8AI6ycHLB8WE1W7KQNYNaSvM9x5qTtRMrFmCRGICPuh6y MzgfGMY7DGhxnRjFzYY8xhheWjsU42H/8FKjoyZZJ/hgpDu54ywJvMh/U1i8oMARcT0e k7g+UXJ3JQnziRpYzW1GXevmy0o5UGDJPfSVQDMTe5MjqWQ88QTkbHpYQEROnwRy0uw3 wgKkksuEazLsHQZEIdPs5lQWegMaaXW3zqxFz7kaF9Y3jf0jRXV8AOj+BNBPXz/1rvwA 5r4A== X-Gm-Message-State: APjAAAWY5DImq/IqmKCYYGXg/Q2Dygw3l9VWJcl8ZnIDVITiTq9mIWyx cga9tU1alTYV1YvDs5hOkMFyiuzeGyLqf5bDQ2VYOaWKrpilKQdzubzsYB2xs1lbpe+x/TU1DRk GJOt45t+UhDz8vEPR2H4Ubol6 X-Received: by 2002:adf:ebc3:: with SMTP id v3mr4130256wrn.280.1579597630114; Tue, 21 Jan 2020 01:07:10 -0800 (PST) X-Google-Smtp-Source: APXvYqxU92Hbv50qsDxzXuliKOZgW+eihOR7bXFm+gNzrAyGGjKZoJ+jAUcQspYmZ2eK0Tb6M8FNyA== X-Received: by 2002:adf:ebc3:: with SMTP id v3mr4130222wrn.280.1579597629862; Tue, 21 Jan 2020 01:07:09 -0800 (PST) Received: from steredhat (host84-49-dynamic.31-79-r.retail.telecomitalia.it. [79.31.49.84]) by smtp.gmail.com with ESMTPSA id r68sm2990217wmr.43.2020.01.21.01.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:07:09 -0800 (PST) Date: Tue, 21 Jan 2020 10:07:06 +0100 From: Stefano Garzarella To: "Michael S. Tsirkin" Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jorgen Hansen , Jason Wang , kvm , Stefan Hajnoczi , virtualization@lists.linux-foundation.org, linux-hyperv@vger.kernel.org, Dexuan Cui Subject: Re: [PATCH net-next 1/3] vsock: add network namespace support Message-ID: References: <20200116172428.311437-1-sgarzare@redhat.com> <20200116172428.311437-2-sgarzare@redhat.com> <20200120.100610.546818167633238909.davem@davemloft.net> <20200120101735.uyh4o64gb4njakw5@steredhat> <20200120060601-mutt-send-email-mst@kernel.org> <20200120110319-mutt-send-email-mst@kernel.org> <20200120170120-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120170120-mutt-send-email-mst@kernel.org> Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Mon, Jan 20, 2020 at 11:02 PM Michael S. Tsirkin wrote: > On Mon, Jan 20, 2020 at 05:53:39PM +0100, Stefano Garzarella wrote: > > On Mon, Jan 20, 2020 at 5:04 PM Michael S. Tsirkin wrote: > > > On Mon, Jan 20, 2020 at 02:58:01PM +0100, Stefano Garzarella wrote: > > > > On Mon, Jan 20, 2020 at 1:03 PM Michael S. Tsirkin wrote: > > > > > On Mon, Jan 20, 2020 at 11:17:35AM +0100, Stefano Garzarella wrote: > > > > > > On Mon, Jan 20, 2020 at 10:06:10AM +0100, David Miller wrote: > > > > > > > From: Stefano Garzarella > > > > > > > Date: Thu, 16 Jan 2020 18:24:26 +0100 > > > > > > > > > > > > > > > This patch adds 'netns' module param to enable this new feature > > > > > > > > (disabled by default), because it changes vsock's behavior with > > > > > > > > network namespaces and could break existing applications. > > > > > > > > > > > > > > Sorry, no. > > > > > > > > > > > > > > I wonder if you can even design a legitimate, reasonable, use case > > > > > > > where these netns changes could break things. > > > > > > > > > > > > I forgot to mention the use case. > > > > > > I tried the RFC with Kata containers and we found that Kata shim-v1 > > > > > > doesn't work (Kata shim-v2 works as is) because there are the following > > > > > > processes involved: > > > > > > - kata-runtime (runs in the init_netns) opens /dev/vhost-vsock and > > > > > > passes it to qemu > > > > > > - kata-shim (runs in a container) wants to talk with the guest but the > > > > > > vsock device is assigned to the init_netns and kata-shim runs in a > > > > > > different netns, so the communication is not allowed > > > > > > But, as you said, this could be a wrong design, indeed they already > > > > > > found a fix, but I was not sure if others could have the same issue. > > > > > > > > > > > > In this case, do you think it is acceptable to make this change in > > > > > > the vsock's behavior with netns and ask the user to change the design? > > > > > > > > > > David's question is what would be a usecase that's broken > > > > > (as opposed to fixed) by enabling this by default. > > > > > > > > Yes, I got that. Thanks for clarifying. > > > > I just reported a broken example that can be fixed with a different > > > > design (due to the fact that before this series, vsock devices were > > > > accessible to all netns). > > > > > > > > > > > > > > If it does exist, you need a way for userspace to opt-in, > > > > > module parameter isn't that. > > > > > > > > Okay, but I honestly can't find a case that can't be solved. > > > > So I don't know whether to add an option (ioctl, sysfs ?) or wait for > > > > a real case to come up. > > > > > > > > I'll try to see better if there's any particular case where we need > > > > to disable netns in vsock. > > > > > > > > Thanks, > > > > Stefano > > > > > > Me neither. so what did you have in mind when you wrote: > > > "could break existing applications"? > > > > I had in mind: > > 1. the Kata case. It is fixable (the fix is not merged on kata), but > > older versions will not work with newer Linux. > > meaning they will keep not working, right? Right, I mean without this series they work, with this series they work only if the netns support is disabled or with a patch proposed but not merged in kata. > > > 2. a single process running on init_netns that wants to communicate with > > VMs handled by VMMs running in different netns, but this case can be > > solved opening the /dev/vhost-vsock in the same netns of the process > > that wants to communicate with the VMs (init_netns in this case), and > > passig it to the VMM. > > again right now they just don't work, right? Right, as above. What do you recommend I do? Thanks, Stefano