From: Linus Torvalds <torvalds@linux-foundation.org>
To: Wei Liu <wei.liu@kernel.org>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Linux on Hyper-V List <linux-hyperv@vger.kernel.org>,
kys@microsoft.com, Stephen Hemminger <sthemmin@microsoft.com>,
haiyangz@microsoft.com, decui@microsoft.com,
Michael Kelley <mikelley@microsoft.com>
Subject: Re: [GIT PULL] Hyper-V fixes for 5.14-rc3
Date: Thu, 22 Jul 2021 10:25:46 -0700 [thread overview]
Message-ID: <CAHk-=wirFvNqAvaNaABHc2mi7FKL4n6TEAwQ3WTyTJueJcHCvA@mail.gmail.com> (raw)
In-Reply-To: <20210722140949.3knhduxozzaido2r@liuwe-devbox-debian-v2>
On Thu, Jul 22, 2021 at 7:09 AM Wei Liu <wei.liu@kernel.org> wrote:
>
> - Reversion of a bogus patch that went into 5.14-rc1
When doing a revert, please explain it.
Yes, they are simple in the sense that they just undo something, but
at the same time, that "something" was done for a reason, and the
reason why that original change was wrong, and how it was noticed (ie
what the symptoms of the reverted patch were) is important.
I've pulled this, so it's too late now, but please please please
explain reverts in the future, not just a "This reverts commit XYZ".
Linus
next prev parent reply other threads:[~2021-07-22 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 14:09 [GIT PULL] Hyper-V fixes for 5.14-rc3 Wei Liu
2021-07-22 17:25 ` Linus Torvalds [this message]
2021-07-22 17:53 ` Wei Liu
2021-07-22 18:00 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wirFvNqAvaNaABHc2mi7FKL4n6TEAwQ3WTyTJueJcHCvA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).