From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ACF8C3815B for ; Mon, 20 Apr 2020 09:26:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F18420CC7 for ; Mon, 20 Apr 2020 09:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725886AbgDTJ0b (ORCPT ); Mon, 20 Apr 2020 05:26:31 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:40954 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbgDTJ0b (ORCPT ); Mon, 20 Apr 2020 05:26:31 -0400 Received: by mail-ot1-f65.google.com with SMTP id i27so7476315ota.7; Mon, 20 Apr 2020 02:26:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vNmHcf3myzOB2u9F8M3SMwCNsUNlPCLfd3zAQRCW16Q=; b=tsioWdIjfcNyzdtGi3K073n0mhYPY+kUfkA7zlx4z9YyUujyKFRAuEkLjfmt7sPW5/ XyUUt+0UmTrle2acO3WkxLxyi/9jOVX2cojs5s2ScVrsYf86YQNAiZ8QhuP4EHcTgoeO n797uzhyL/7TGsHl5hrE6lPqKOVkE54qXywflKLMBgXMOwCr2rY1CsOiwcaK6jAs3E/L neL0a+7hjpNo0ORQeDYzTQ826wJqwLiZap0m27BuUsi4zJJ8EjXbHzmHU8Yk5vA+Xaon 2zp1ZFHhxnkLovN+O1hThb+9rKm3kLb1K0eNkjMdHyQzIMpPv1LXgf8uDxnV1CaSv8nj C1xQ== X-Gm-Message-State: AGi0PuYhD4Rw5340fIWGN7gF6K/yqGg+7Rnee41H5qk+erFWZfUSGK3e iF7bpLAflzmOcnZXx2B1qS8olXNChhJfi3npwAU= X-Google-Smtp-Source: APiQypLK0nAWizIJ4tO6vPe5OvpMxqQr4fd7LV61E3+C9yzFgEDzCpkHgr7Sqg0Lx1T9RyK7Z05pBaDYg8OyPFQJ0Pw= X-Received: by 2002:a05:6830:3104:: with SMTP id b4mr5221130ots.250.1587374790460; Mon, 20 Apr 2020 02:26:30 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-27-hch@lst.de> In-Reply-To: <20200414131348.444715-27-hch@lst.de> From: Geert Uytterhoeven Date: Mon, 20 Apr 2020 11:26:19 +0200 Message-ID: Subject: Re: [PATCH 26/29] mm: remove vmalloc_user_node_flags To: Christoph Hellwig Cc: Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , "the arch/x86 maintainers" , David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Christophe Leroy , Linux-Arch , linux-hyperv@vger.kernel.org, linux-s390 , Peter Zijlstra , linuxppc-dev , Linux Kernel Mailing List , DRI Development , linaro-mm-sig@lists.linaro.org, Linux MM , Linux IOMMU , Johannes Weiner , bpf , Robin Murphy , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org Hi Christoph, On Tue, Apr 14, 2020 at 3:22 PM Christoph Hellwig wrote: > Open code it in __bpf_map_area_alloc, which is the only caller. Also > clean up __bpf_map_area_alloc to have a single vmalloc call with > slightly different flags instead of the current two different calls. > > For this to compile for the nommu case add a __vmalloc_node_range stub > to nommu.c. Apparently your nommu-cross-compilers are in quarantaine? ;-) > Signed-off-by: Christoph Hellwig > Acked-by: Peter Zijlstra (Intel) > Acked-by: Johannes Weiner > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -150,6 +150,14 @@ void *__vmalloc(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL(__vmalloc); > > +void *__vmalloc_node_range(unsigned long size, unsigned long align, > + unsigned long start, unsigned long end, gfp_t gfp_mask, > + pgprot_t prot, unsigned long vm_flags, int node, > + const void *caller) > +{ > + return __vmalloc(size, flags); On Mon, Apr 20, 2020 at 10:39 AM wrote: > FAILED linux-next/m5272c3_defconfig/m68k-gcc8 Mon Apr 20, 18:38 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:158:25: error: 'flags' undeclared (first use in this function); did you mean 'class'? "return __vmalloc(size, gfp_mask);", I assume? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds