From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 267BCC3A59D for ; Tue, 20 Aug 2019 12:38:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE92C22CF7 for ; Tue, 20 Aug 2019 12:38:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LJOIlwqN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729844AbfHTMiW (ORCPT ); Tue, 20 Aug 2019 08:38:22 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40425 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729383AbfHTMiW (ORCPT ); Tue, 20 Aug 2019 08:38:22 -0400 Received: by mail-pg1-f196.google.com with SMTP id w10so3184787pgj.7; Tue, 20 Aug 2019 05:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nPEeXkHVugtuWFlIz8GtMsMv1+S0Lha6cbNZpxpRArU=; b=LJOIlwqNYHXD7cHZ6EOsmob8xvknsOMLrMfO5zhrO/hlOWCbl9oRhwtm6GgYdix2xu er230DjbgsQiYIUvGeSCtB/XU+iCevsrploFnAK3HjojGToNX3MeX+f3z/WRg2j1Q7xa vUTX4He41+Um9Hj+tyTyBgDEwdDaMgrIqsgXJom2/xdfqHRguDhVy+xCHIRVJUg35sw2 v39oOT5FZyi8moTwiCsatiaiE1FMrKTuHTp/hDmSNmT68FzLGFXSH8cJpKBoqkVfqXIF kN8k2VksGohU40xiIxRPVyFZ9SpWPms3lbT/tIhWAMUB9tF+4pGAzRm8ZMgvLl5RqOOF cEUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nPEeXkHVugtuWFlIz8GtMsMv1+S0Lha6cbNZpxpRArU=; b=rsDxLZB8Ol9Z1JkEpKv7TqgFOIFUX4cgnQormXapeQlUs3p+J3FLlwJG+1Bqsd/b4F 5pSJ/xOmZJWEa/I5klFwN3Qyj0W1gee4GIFxuqg5fk1r2mbrPq0aBX0m1CFhCKqzaDjp MWODilI6oa5T4UyWSdyHTSKkWsv8JIwLsHHgezGtibP8u2ZKMQwLuxL6I0wyPIpUWWEX S7LW0blJQTZOCYA3ijcvYPXMEGEuskGuTg+sMcPtsDjnHRwpw1l36FKO0LEdL75Ny28V K+rg2+6zEZIpGSsIE0Qg32lFnILS2VgKyfSj+g4ZW5YiW/rdqfdYylGIC4n+ZmpQpwmQ LwWA== X-Gm-Message-State: APjAAAUd3nO+H5mBxAhsL321nsAJBJQlIUzSS98G9UsaVvwEZt3faF5a aMXxrrOM1Y+F8z8IKqnWQJ61qiLin4FDPv1KxnQ= X-Google-Smtp-Source: APXvYqwggjmfndZ9vdx+84JSw4dPC+8rQAoRcmAZ/Rgr8ykhjxqa0jdGrCOY5Bb3JWVdr8YvApTm37u9Tm5cVXV+lE4= X-Received: by 2002:a65:5043:: with SMTP id k3mr25355913pgo.406.1566304701388; Tue, 20 Aug 2019 05:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20190819131737.26942-1-Tianyu.Lan@microsoft.com> <20190819131737.26942-3-Tianyu.Lan@microsoft.com> In-Reply-To: From: Tianyu Lan Date: Tue, 20 Aug 2019 20:38:11 +0800 Message-ID: Subject: Re: [PATCH V3 2/3] KVM/Hyper-V: Add new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH To: Thomas Gleixner Cc: Paolo Bonzini , Radim Krcmar , corbet@lwn.net, KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Sasha Levin , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , michael.h.kelley@microsoft.com, Tianyu Lan , kvm , linux-doc@vger.kernel.org, "linux-kernel@vger kernel org" , linux-hyperv@vger.kernel.org, Vitaly Kuznetsov Content-Type: text/plain; charset="UTF-8" Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org Hi Thomas: Thanks for your review. Will fix your comment in the next version. On Mon, Aug 19, 2019 at 9:27 PM Thomas Gleixner wrote: > > On Mon, 19 Aug 2019, lantianyu1986@gmail.com wrote: > > > From: Tianyu Lan > > > > This patch adds > > Same git grep command as before > > > new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH and let > > baseball cap? Please do not use weird acronyms. This is text and there is > not limitation on characters. > > > user space to enable direct tlb flush function when only Hyper-V > > hypervsior capability is exposed to VM. > > Sorry, but I'm not understanding this sentence. > > > This patch also adds > > Once more > > > enable_direct_tlbflush callback in the struct kvm_x86_ops and > > platforms may use it to implement direct tlb flush support. > > Please tell in the changelog WHY you are doing things not what. The what is > obviously in the patch. > > So you want to explain what you are trying to achieve and why it is > useful. Then you can add a short note about what you are adding, but not at > the level of detail which is available from the diff itself. > > Thanks, > > tglx -- Best regards Tianyu Lan