From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8371AC8300C for ; Thu, 30 Apr 2020 08:12:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6315A2073E for ; Thu, 30 Apr 2020 08:12:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="aRdqN+ob" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbgD3IMH (ORCPT ); Thu, 30 Apr 2020 04:12:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726571AbgD3IMH (ORCPT ); Thu, 30 Apr 2020 04:12:07 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D03C0C08E859 for ; Thu, 30 Apr 2020 01:12:06 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id x1so3927783ejd.8 for ; Thu, 30 Apr 2020 01:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aPyH7cBulXkr69UeTYsLw8J8jsMaQ8KU1AV45QxO0GM=; b=aRdqN+obvpVV2A+fgMLJy4RekybxRVDiG7lp8OF4bnZx2Ywvd3iCU/W+kNS4ZeZMFO s2KHcqmsaIITIji0juOY7H6rW7Fc6dWrzMOI3EIosswh9jq3YYccKaX2xhcXTvz1nd5V aBV+pihhUiUdyrUO5BWYQElkaX6/osTUoFcDUd3gIMpaDgbgaWZ7XiKQfHXqUsjsTevr xcbBoOAzO8ZeJrHgjs2FlN5xkisQM2/NaUdROIGlFFS2pMP9xFv8klIZrmKxkYMDnngC ZkScurbP2qpL3FH2QS0j799ldY6mMF4VeS1bCDMrE9KedwDuMF2flKOw3iR6FucwjAe8 uO/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aPyH7cBulXkr69UeTYsLw8J8jsMaQ8KU1AV45QxO0GM=; b=PyGSgvpB9ZtvOy/NzryRcCgwNOBNDRbH1aMsRifynYU4fB3kvEmSa9vvhN9bEGbTTR 5WFBhv0+9W6wkFYjORS4jwJH3W/OFs8l3BMErlPtpo2bciWFbEtgQxifxEtJeiYsnZWk pziKNo4Nab9kSlsCfXdkfaolfvu6ZWlEQPJpzIaWuYL9yCGMWEqLsbWwt/y7e6yPYTcv /ASxBoGIbVzIbtbhMfWwRsofmd+tfJKogkg+jdf5r6fe7mfPa7WZZFwCYI5QyY7ZUiF5 IkDDD1Rrll/hLa0fGJzw2GfV88LBJ+q6/0fsGQB45QDLmjFKihrVVCuy1Fni//nE8yg3 nKNg== X-Gm-Message-State: AGi0Pua1ov9mlaGPjkNzUmB7S+n9FVJ0+wnDc8RerzgLwgdEUFp3xE99 G9Bwh3QsRN95W73oob2bMIELarAvT883KWCTohWjSQ== X-Google-Smtp-Source: APiQypKwCBG4S6M4oBR8TWLxl5ZHi3zkP+L9vXXaCbuE040rlsosdGPooBbFU8EQOuJGeo1PTMYPgjG4Ewt4MDGe5kI= X-Received: by 2002:a17:906:7750:: with SMTP id o16mr1646531ejn.12.1588234325407; Thu, 30 Apr 2020 01:12:05 -0700 (PDT) MIME-Version: 1.0 References: <20200429160803.109056-1-david@redhat.com> <20200429160803.109056-3-david@redhat.com> In-Reply-To: From: Dan Williams Date: Thu, 30 Apr 2020 01:11:54 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] mm/memory_hotplug: Introduce MHP_DRIVER_MANAGED To: David Hildenbrand Cc: Linux Kernel Mailing List , Linux MM , virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, linuxppc-dev , Linux ACPI , linux-nvdimm , linux-hyperv@vger.kernel.org, linux-s390 , xen-devel , Michal Hocko , Andrew Morton , "Michael S . Tsirkin" , Michal Hocko , Pankaj Gupta , Wei Yang , Baoquan He , Eric Biederman , Pavel Tatashin , Dave Hansen Content-Type: text/plain; charset="UTF-8" Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Thu, Apr 30, 2020 at 12:20 AM David Hildenbrand wrote: > > On 29.04.20 18:08, David Hildenbrand wrote: > > Some paravirtualized devices that add memory via add_memory() and > > friends (esp. virtio-mem) don't want to create entries in > > /sys/firmware/memmap/ - primarily to hinder kexec from adding this > > memory to the boot memmap of the kexec kernel. > > > > In fact, such memory is never exposed via the firmware (e.g., e820), but > > only via the device, so exposing this memory via /sys/firmware/memmap/ is > > wrong: > > "kexec needs the raw firmware-provided memory map to setup the > > parameter segment of the kernel that should be booted with > > kexec. Also, the raw memory map is useful for debugging. For > > that reason, /sys/firmware/memmap is an interface that provides > > the raw memory map to userspace." [1] > > > > We want to let user space know that memory which is always detected, > > added, and managed via a (device) driver - like memory managed by > > virtio-mem - is special. It cannot be used for placing kexec segments > > and the (device) driver is responsible for re-adding memory that > > (eventually shrunk/grown/defragmented) memory after a reboot/kexec. It > > should e.g., not be added to a fixed up firmware memmap. However, it should > > be dumped by kdump. > > > > Also, such memory could behave differently than an ordinary DIMM - e.g., > > memory managed by virtio-mem can have holes inside added memory resource, > > which should not be touched, especially for writing. > > > > Let's expose that memory as "System RAM (driver managed)" e.g., via > > /pro/iomem. > > > > We don't have to worry about firmware_map_remove() on the removal path. > > If there is no entry, it will simply return with -EINVAL. > > > > [1] https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-firmware-memmap > > > > Cc: Andrew Morton > > Cc: Michal Hocko > > Cc: Pankaj Gupta > > Cc: Wei Yang > > Cc: Baoquan He > > Cc: Eric Biederman > > Signed-off-by: David Hildenbrand > > --- > > include/linux/memory_hotplug.h | 8 ++++++++ > > mm/memory_hotplug.c | 20 ++++++++++++++++---- > > 2 files changed, 24 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > > index bf0e3edb8688..cc538584b39e 100644 > > --- a/include/linux/memory_hotplug.h > > +++ b/include/linux/memory_hotplug.h > > @@ -68,6 +68,14 @@ struct mhp_params { > > pgprot_t pgprot; > > }; > > > > +/* Flags used for add_memory() and friends. */ > > + > > +/* > > + * Don't create entries in /sys/firmware/memmap/ and expose memory as > > + * "System RAM (driver managed)" in e.g., /proc/iomem > > + */ > > +#define MHP_DRIVER_MANAGED 1 > > + > > /* > > * Zone resizing functions > > * > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index ebdf6541d074..cfa0721280aa 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -98,11 +98,11 @@ void mem_hotplug_done(void) > > u64 max_mem_size = U64_MAX; > > > > /* add this memory to iomem resource */ > > -static struct resource *register_memory_resource(u64 start, u64 size) > > +static struct resource *register_memory_resource(u64 start, u64 size, > > + const char *resource_name) > > { > > struct resource *res; > > unsigned long flags = IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY; > > - char *resource_name = "System RAM"; > > > > /* > > * Make sure value parsed from 'mem=' only restricts memory adding > > @@ -1058,7 +1058,8 @@ int __ref add_memory_resource(int nid, struct resource *res, > > BUG_ON(ret); > > > > /* create new memmap entry */ > > - firmware_map_add_hotplug(start, start + size, "System RAM"); > > + if (!(flags & MHP_DRIVER_MANAGED)) > > + firmware_map_add_hotplug(start, start + size, "System RAM"); > > > > /* device_online() will take the lock when calling online_pages() */ > > mem_hotplug_done(); > > @@ -1081,10 +1082,21 @@ int __ref add_memory_resource(int nid, struct resource *res, > > /* requires device_hotplug_lock, see add_memory_resource() */ > > int __ref __add_memory(int nid, u64 start, u64 size, unsigned long flags) > > { > > + const char *resource_name = "System RAM"; > > struct resource *res; > > int ret; > > > > - res = register_memory_resource(start, size); > > + /* > > + * Indicate that memory managed by a driver is special. It's always > > + * detected and added via a driver, should not be given to the kexec > > + * kernel for booting when manually crafting the firmware memmap, and > > + * no kexec segments should be placed on it. However, kdump should > > + * dump this memory. > > + */ > > + if (flags & MHP_DRIVER_MANAGED) > > + resource_name = "System RAM (driver managed)"; > > + > > + res = register_memory_resource(start, size, resource_name); > > if (IS_ERR(res)) > > return PTR_ERR(res); > > > > > > BTW, I was wondering if this is actually also something that > drivers/dax/kmem.c wants to use for adding memory. > > Just because we decided to use some DAX memory in the current kernel as > system ram, doesn't mean we should make that decision for the kexec > kernel (e.g., using it as initial memory, placing kexec binaries onto > it, etc.). This is also not what we would observe during a real reboot. Agree. > I can see that the "System RAM" resource will show up as child resource > under the device e.g., in /proc/iomem. > > However, entries in /sys/firmware/memmap/ are created as "System RAM". True. Do you think this rename should just be limited to what type /sys/firmware/memmap/ emits? I have the concern, but no proof currently, that there are /proc/iomem walkers that explicitly look for "System RAM", but might be thrown off by "System RAM (driver managed)". I was not aware of /sys/firmware/memmap until about 5 minutes ago.