From: Michael Kelley <mikelley@microsoft.com>
To: "Andrea Parri (Microsoft)" <parri.andrea@gmail.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 8/8] Drivers: hv: vmbus: Remove the lock field from the vmbus_channel struct
Date: Thu, 18 Jun 2020 18:35:48 +0000 [thread overview]
Message-ID: <DM5PR2101MB10472446CC72A17FE2A78920D79B0@DM5PR2101MB1047.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200617164642.37393-9-parri.andrea@gmail.com>
From: Andrea Parri (Microsoft) <parri.andrea@gmail.com> Sent: Wednesday, June 17, 2020 9:47 AM
>
> The spinlock is (now) *not used to protect test-and-set accesses
> to attributes of the structure or sc_list operations.
>
> There is, AFAICT, a distinct lack of {WRITE,READ}_ONCE()s in the
> handling of channel->state, but the changes below do not seem to
> make things "worse". ;-)
>
> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
> ---
> drivers/hv/channel.c | 6 +-----
> drivers/hv/channel_mgmt.c | 1 -
> include/linux/hyperv.h | 6 ------
> 3 files changed, 1 insertion(+), 12 deletions(-)
>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
next prev parent reply other threads:[~2020-06-18 18:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 16:46 [PATCH 0/8] Drivers: hv: vmbus: Miscellaneous cleanups Andrea Parri (Microsoft)
2020-06-17 16:46 ` [PATCH 1/8] Drivers: hv: vmbus: Remove the target_vp field from the vmbus_channel struct Andrea Parri (Microsoft)
2020-06-18 15:24 ` Michael Kelley
2020-06-17 16:46 ` [PATCH 2/8] Drivers: hv: vmbus: Remove the numa_node " Andrea Parri (Microsoft)
2020-06-18 15:26 ` Michael Kelley
2020-06-17 16:46 ` [PATCH 3/8] Drivers: hv: vmbus: Replace cpumask_test_cpu(, cpu_online_mask) with cpu_online() Andrea Parri (Microsoft)
2020-06-18 15:27 ` Michael Kelley
2020-06-17 16:46 ` [PATCH 4/8] Drivers: hv: vmbus: Remove unnecessary channel->lock critical sections (sc_list readers) Andrea Parri (Microsoft)
2020-06-18 15:29 ` Michael Kelley
2020-06-17 16:46 ` [PATCH 5/8] Drivers: hv: vmbus: Use channel_mutex in channel_vp_mapping_show() Andrea Parri (Microsoft)
2020-06-18 18:31 ` Michael Kelley
2020-06-17 16:46 ` [PATCH 6/8] Drivers: hv: vmbus: Remove unnecessary channel->lock critical sections (sc_list updaters) Andrea Parri (Microsoft)
2020-06-18 18:32 ` Michael Kelley
2020-06-17 16:46 ` [PATCH 7/8] scsi: storvsc: Introduce the per-storvsc_device spinlock Andrea Parri (Microsoft)
2020-06-18 18:34 ` Michael Kelley
2020-06-19 16:01 ` Wei Liu
2020-06-19 16:18 ` Andrea Parri
2020-06-20 2:58 ` Martin K. Petersen
2020-06-20 9:15 ` Wei Liu
2020-06-17 16:46 ` [PATCH 8/8] Drivers: hv: vmbus: Remove the lock field from the vmbus_channel struct Andrea Parri (Microsoft)
2020-06-18 18:35 ` Michael Kelley [this message]
2020-06-19 15:39 ` [PATCH 0/8] Drivers: hv: vmbus: Miscellaneous cleanups Wei Liu
2020-06-19 15:56 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR2101MB10472446CC72A17FE2A78920D79B0@DM5PR2101MB1047.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).