From: Dexuan Cui <decui@microsoft.com>
To: Michael Kelley <mikelley@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"sashal@kernel.org" <sashal@kernel.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
vkuznets <vkuznets@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 3/4] hv_utils: Support host-initiated hibernation request
Date: Thu, 23 Jan 2020 08:11:19 +0000 [thread overview]
Message-ID: <HK0P153MB014846CCBBA8C989EEC8819BBF0F0@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <DM5PR2101MB10477532BDC475656FA3817AD70C0@DM5PR2101MB1047.namprd21.prod.outlook.com>
> From: Michael Kelley <mikelley@microsoft.com>
> > --- a/drivers/hv/hv_util.c
> > +++ b/drivers/hv/hv_util.c
> > ...
> > static const int sd_versions[] = {
> > SD_VERSION_3_1,
> > + SD_VERSION_3_2,
>
> I think these versions need to listed in descending order, so the new
> SD_VERSION_3_2 should be listed first. Otherwise a Hyper-V host that
> supports both 3.1 and 3.2 might match on 3.1 first without ever checking
> for a match with 3.2.
Thanks! This is a rebasing mistake. Will fix it.
> > @@ -187,6 +226,17 @@ static void shutdown_onchannelcallback(void
> *context)
> >
> > schedule_work(&restart_work);
> > break;
> > + case 4:
> > + case 5:
>
> As before, I'm wondering about the interpretation of these numbers.
Will add a comment.
> > + pr_info("Hibernation request received\n");
> > +
> > + if (execute_hibernate) {
> > + icmsghdrp->status = HV_S_OK;
> > + schedule_work(&hibernate_context.work);
>
> Same comment here about the ordering of the schedule_work() call and the
> sending of the response message. Seems like the code should be consistent
> for all three cases -- shutdown, restart, and hibernate.
I agree. Will fix this.
Thanks,
-- Dexuan
prev parent reply other threads:[~2020-01-23 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 6:31 [PATCH v2 3/4] hv_utils: Support host-initiated hibernation request Dexuan Cui
2020-01-22 17:39 ` Michael Kelley
2020-01-23 8:11 ` Dexuan Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK0P153MB014846CCBBA8C989EEC8819BBF0F0@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM \
--to=decui@microsoft.com \
--cc=Alexander.Levin@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).