From: Dexuan Cui <decui@microsoft.com>
To: KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"sashal@kernel.org" <sashal@kernel.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
vkuznets <vkuznets@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/4] hv_utils: Add the support of hibernation
Date: Mon, 13 Jan 2020 22:21:18 +0000 [thread overview]
Message-ID: <HK0P153MB0148F30D914976A906B35427BF350@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <HK0P153MB0148968D9EFBFAE1E881674CBF350@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM>
> From: Dexuan Cui
> Sent: Sunday, January 12, 2020 10:29 PM
>
> Hi,
> This is an updated version of the v1 patchset:
> https://lkml.org/lkml/2019/9/11/861
>
> Patch #1 is a new patch that makes the daemons more robust.
>
> Patch #2 is the same as v1.
>
> Patch #3 sends the host-initiated hibernation request to the user space via
> udev.
> (v1 used call_usermodehelper() and "/sbin/hyperv-hibernate".)
>
> Patch #4 handles fcopy/vss specially to avoid possible inconsistent states.
>
> Please review.
>
> Thanks!
>
> Dexuan Cui (4):
> Patch #1: Tools: hv: Reopen the devices if read() or write() returns errors
> Patch #2: hv_utils: Support host-initiated restart request
> Patch #3: hv_utils: Support host-initiated hibernation request
> Patch #4: hv_utils: Add the support of hibernation
Hi Vitaly,
I forgot to mention this for patch #4: IMO we don't need to add a new
HVUTIL_SUSPENDED state to the hvutil state machine, because:
When we reach util_suspend(), all the userspace processes have been
frozen: see kernel/power/hibernate.c: hibernate() -> freeze_processes() ->
try_to_freeze_tasks(true) -> freeze_task() -> fake_signal_wake_up(). When
try_to_freeze_tasks(true) returns 0, all the user-space processes must be
frozen in do_signal() -> get_signal() -> try_to_freeze() -> ... -> __refrigerator().
hibernate () -> hibernation_snapshot () -> dpm_suspend() -> ... ->
util_suspend() only runs after hibernate() -> freeze_processes(), so I'm
pretty sure we have no race condition with the user space daemon.
util_suspend() -> srv->util_pre_suspend() disables the tasklet and cancels any
pening work items, so there is no race in the kernel space, either.
Thanks,
-- Dexuan
prev parent reply other threads:[~2020-01-13 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 6:29 [PATCH v2 0/4] hv_utils: Add the support of hibernation Dexuan Cui
2020-01-13 22:21 ` Dexuan Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK0P153MB0148F30D914976A906B35427BF350@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM \
--to=decui@microsoft.com \
--cc=Alexander.Levin@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).