Linux-HyperV Archive on
 help / color / Atom feed
From: Dexuan Cui <>
To: "Gustavo A. R. Silva" <>,
	KY Srinivasan <>,
	Haiyang Zhang <>,
	Stephen Hemminger <>,
	Sasha Levin <>,
	Lorenzo Pieralisi <>,
	Andrew Murray <>,
	Bjorn Helgaas <>
Cc: "" <>,
	"" <>,
	"" <>
Subject: RE: [PATCH] PCI: hv: Replace zero-length array with flexible-array member
Date: Thu, 13 Feb 2020 03:43:40 +0000
Message-ID: <HK0P153MB0148FB68FCBAE908CA5991C3BF1A0@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <>

> From:
> <> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, February 12, 2020 4:51 PM
>  ...
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
> struct foo {
>         int stuff;
>         struct boo array[];
> };
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertently introduced[3] to the codebase from now on.
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of
> zero-length arrays, sizeof evaluates to zero."[1]
> This issue was found with the help of Coccinelle.

Looks good to me. Thanks, Gustavo!
Reviewed-by: Dexuan Cui <>

FWIW, it looks there are a lot of more to fix in the kernel tree: the below
commands return 1373 for me:

grep -nr '\[0\];$' * | grep '\.h:' | grep -v = | wc -l

Running the commands against the kernel/ directory returns 3.

-- Dexuan

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  0:50 Gustavo A. R. Silva
2020-02-13  3:43 ` Dexuan Cui [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HK0P153MB0148FB68FCBAE908CA5991C3BF1A0@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-HyperV Archive on

Archives are clonable:
	git clone --mirror linux-hyperv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-hyperv linux-hyperv/ \
	public-inbox-index linux-hyperv

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone