From: Michael Kelley <mikelley@microsoft.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
KY Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Drivers: hv: vmbus: remove unused function
Date: Wed, 14 Apr 2021 14:48:17 +0000 [thread overview]
Message-ID: <MWHPR21MB15933A7D469B6FF2E60368A6D74E9@MWHPR21MB1593.namprd21.prod.outlook.com> (raw)
In-Reply-To: <1618381282-119135-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Sent: Tuesday, April 13, 2021 11:21 PM
>
> Fix the following clang warning:
>
> drivers/hv/ring_buffer.c:89:1: warning: unused function
> 'hv_set_next_read_location' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/hv/ring_buffer.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
> index 35833d4..78d4043 100644
> --- a/drivers/hv/ring_buffer.c
> +++ b/drivers/hv/ring_buffer.c
> @@ -84,15 +84,6 @@ static void hv_signal_on_write(u32 old_write, struct vmbus_channel
> *channel)
> ring_info->ring_buffer->write_index = next_write_location;
> }
>
> -/* Set the next read location for the specified ring buffer. */
> -static inline void
> -hv_set_next_read_location(struct hv_ring_buffer_info *ring_info,
> - u32 next_read_location)
> -{
> - ring_info->ring_buffer->read_index = next_read_location;
> - ring_info->priv_read_index = next_read_location;
> -}
> -
> /* Get the size of the ring buffer. */
> static inline u32
> hv_get_ring_buffersize(const struct hv_ring_buffer_info *ring_info)
> --
> 1.8.3.1
This function became unused as of commit 4226ff69a3df
("vmbus: simplify hv_ringbuffer_read") on 7/17/2017.
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
next prev parent reply other threads:[~2021-04-14 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 6:21 [PATCH] Drivers: hv: vmbus: remove unused function Jiapeng Chong
2021-04-14 14:48 ` Michael Kelley [this message]
2021-04-14 15:15 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR21MB15933A7D469B6FF2E60368A6D74E9@MWHPR21MB1593.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).