From: Michael Kelley <mikelley@microsoft.com>
To: David Mozes <david.mozes@silk.us>,
"20201001013814.2435935-1-sashal@kernel.org"
<20201001013814.2435935-1-sashal@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Subject: RE: [PATCH] x86/hyper-v: guard against cpu mask changes in hyperv_flush_tlb_others()
Date: Thu, 5 Aug 2021 18:08:04 +0000 [thread overview]
Message-ID: <MWHPR21MB15937C5C151589EE999ABC63D7F29@MWHPR21MB1593.namprd21.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0401MB24150B31A1D63176BBB788D2F1F19@VI1PR0401MB2415.eurprd04.prod.outlook.com>
From: David Mozes <david.mozes@silk.us>
>
> Hi,
> The problem is happening to me very frequently on kernel 4.19.195
>
David -- could you give us a little more context? Were you running earlier
4.19.xxx versions and did not see this problem? There was a timing
problem in hyperv_flush_tlb_others() that was fixed in early January
2021. The fix was backported to the 4.19 longterm tree, and should
be included in 4.19.195. Outside of that, I'm not aware of a problem
in this area.
For completeness, what version of Hyper-V are you using? And how
many vCPUs in your VM?
Michael
>
>
> ug 4 03:59:01 c-node04 kernel: [36976.388554] BUG: KASAN: slab-out-of-bounds in hyperv_flush_tlb_others+0xec9/0x1640
> Aug 4 03:59:01 c-node04 kernel: [36976.388556] Read of size 4 at addr ffff889e5e127440 by task ps/52478
> Aug 4 03:59:01 c-node04 kernel: [36976.388556]
> Aug 4 03:59:01 c-node04 kernel: [36976.388560] CPU: 4 PID: 52478 Comm: ps Kdump: loaded Tainted: G W OE
> 4.19.195-KM9 #1
> Aug 4 03:59:01 c-node04 kernel: [36976.388562] Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine,
> BIOS 090008 12/07/2018
> Aug 4 03:59:01 c-node04 kernel: [36976.388562] Call Trace:
> Aug 4 03:59:01 c-node04 kernel: [36976.388569] dump_stack+0x11d/0x1a7
> Aug 4 03:59:01 c-node04 kernel: [36976.388572] ? dump_stack_print_info.cold.0+0x1b/0x1b
> Aug 4 03:59:01 c-node04 kernel: [36976.388576] ? percpu_ref_tryget_live+0x2f0/0x2f0
> Aug 4 03:59:01 c-node04 kernel: [36976.388580] ? rb_erase_cached+0xc4c/0x2880
> Aug 4 03:59:01 c-node04 kernel: [36976.388584] ? printk+0x9f/0xc5
> Aug 4 03:59:01 c-node04 kernel: [36976.388585] ? snapshot_ioctl.cold.1+0x74/0x74
> Aug 4 03:59:01 c-node04 kernel: [36976.388590] print_address_description+0x65/0x22e
> Aug 4 03:59:01 c-node04 kernel: [36976.388592] kasan_report.cold.6+0x243/0x2ff
> Aug 4 03:59:01 c-node04 kernel: [36976.388594] ? hyperv_flush_tlb_others+0xec9/0x1640
> Aug 4 03:59:01 c-node04 kernel: [36976.388596] hyperv_flush_tlb_others+0xec9/0x1640
> Aug 4 03:59:01 c-node04 kernel: [36976.388601] ?
> trace_event_raw_event_hyperv_nested_flush_guest_mapping+0x1b0/0x1b0
> Aug 4 03:59:01 c-node04 kernel: [36976.388603] ? mem_cgroup_try_charge+0x3cc/0x7d0
> Aug 4 03:59:01 c-node04 kernel: [36976.388608] flush_tlb_mm_range+0x25c/0x370
> Aug 4 03:59:01 c-node04 kernel: [36976.388611] ? native_flush_tlb_others+0x3b0/0x3b0
> Aug 4 03:59:01 c-node04 kernel: [36976.388616] ptep_clear_flush+0x192/0x1d0
> Aug 4 03:59:01 c-node04 kernel: [36976.388618] ? pmd_clear_bad+0x70/0x70
> Aug 4 03:59:01 c-node04 kernel: [36976.388622] wp_page_copy+0x861/0x1a30
> Aug 4 03:59:01 c-node04 kernel: [36976.388624] ? follow_pfn+0x2f0/0x2f0
> Aug 4 03:59:01 c-node04 kernel: [36976.388627] ? active_load_balance_cpu_stop+0x10d0/0x10d0
> Aug 4 03:59:01 c-node04 kernel: [36976.388632] ? get_page_from_freelist+0x330c/0x4660
> Aug 4 03:59:01 c-node04 kernel: [36976.388638] ? activate_page+0x660/0x660
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? rb_erase+0x2a40/0x2a40
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? wake_up_page_bit+0x4d0/0x4d0
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? unwind_next_frame+0x113e/0x1920
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? __pte_alloc_kernel+0x350/0x350
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? deref_stack_reg+0x130/0x130
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] do_wp_page+0x461/0x1ca0
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? deref_stack_reg+0x130/0x130
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? finish_mkwrite_fault+0x710/0x710
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? unwind_next_frame+0x105d/0x1920
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? entry_SYSCALL_64_after_hwframe+0x44/0xa9
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? __pte_alloc_kernel+0x350/0x350
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? __zone_watermark_ok+0x33c/0x640
> Aug 4 03:59:01 c-node04 kernel: [36976.388639] ? _raw_spin_lock+0x13/0x30
> Pattern not found (press RETURN)
next parent reply other threads:[~2021-08-05 18:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR0401MB24150B31A1D63176BBB788D2F1F19@VI1PR0401MB2415.eurprd04.prod.outlook.com>
2021-08-05 18:08 ` Michael Kelley [this message]
[not found] <CA+qYZY3a-FHfWNL2=na6O8TRJYu9kaeyp80VNDxaDTi2EBGoog@mail.gmail.com>
2021-08-06 10:43 ` [PATCH] x86/hyper-v: guard against cpu mask changes in hyperv_flush_tlb_others() Michael Kelley
2021-08-06 17:35 ` David Mozes
[not found] ` <CAHkVu0-ZCXDRZL92d_G3oKpPuKvmY=YEbu9nbx9vkZHnhHFD8Q@mail.gmail.com>
2021-08-06 21:51 ` Michael Kelley
2021-08-07 5:00 ` David Moses
2021-08-17 9:16 ` David Mozes
2021-08-17 11:29 ` Wei Liu
2021-08-19 11:05 ` David Mozes
[not found] ` <CA+qYZY1U04SkyHo7X+rDeE=nUy_X5nxLfShyuLJFzXnFp2A6uw@mail.gmail.com>
[not found] ` <VI1PR0401MB24153DEC767B0126B1030E07F1C09@VI1PR0401MB2415.eurprd04.prod.outlook.com>
2021-08-22 15:24 ` Wei Liu
2021-08-22 16:25 ` David Mozes
2021-08-22 17:32 ` Wei Liu
2020-10-01 1:38 Sasha Levin
2020-10-01 9:40 ` Vitaly Kuznetsov
2020-10-01 11:53 ` Wei Liu
2020-10-01 13:04 ` Sasha Levin
2020-10-03 17:40 ` Michael Kelley
2020-10-05 14:58 ` Wei Liu
2021-01-05 16:59 ` Michael Kelley
2021-01-05 17:10 ` Wei Liu
2021-01-08 15:22 ` Sasha Levin
2020-10-01 13:10 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR21MB15937C5C151589EE999ABC63D7F29@MWHPR21MB1593.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=20201001013814.2435935-1-sashal@kernel.org \
--cc=david.mozes@silk.us \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).