From: Michael Kelley <mikelley@microsoft.com>
To: Wei Liu <wei.liu@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>
Cc: "will@kernel.org" <will@kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"ardb@kernel.org" <ardb@kernel.org>
Subject: RE: [PATCH v12 5/5] Drivers: hv: Enable Hyper-V code to be built on ARM64
Date: Wed, 4 Aug 2021 16:43:00 +0000 [thread overview]
Message-ID: <MWHPR21MB15939FD6BE722550ED25FA5CD7F19@MWHPR21MB1593.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20210804164029.6xmloksmssrdsmvo@liuwe-devbox-debian-v2>
From: Wei Liu <wei.liu@kernel.org> Sent: Wednesday, August 4, 2021 9:40 AM
>
> On Wed, Aug 04, 2021 at 05:10:41PM +0100, Catalin Marinas wrote:
> > On Wed, Aug 04, 2021 at 08:52:39AM -0700, Michael Kelley wrote:
> > > Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on
> > > ARM64, causing the Hyper-V specific code to be built. Exclude the
> > > Hyper-V enlightened clocks/timers code from being built for ARM64.
> > >
> > > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
> > > Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
> > > Acked-by: Marc Zyngier <maz@kernel.org>
> > > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > >
> > > ---
> > > drivers/hv/Kconfig | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> > > index 66c794d..e509d5d 100644
> > > --- a/drivers/hv/Kconfig
> > > +++ b/drivers/hv/Kconfig
> > > @@ -4,7 +4,8 @@ menu "Microsoft Hyper-V guest support"
> > >
> > > config HYPERV
> > > tristate "Microsoft Hyper-V client drivers"
> > > - depends on X86 && ACPI && X86_LOCAL_APIC && HYPERVISOR_GUEST
> > > + depends on ACPI && ((X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \
> > > + || (ARM64 && !CPU_BIG_ENDIAN))
> > > select PARAVIRT
> > > select X86_HV_CALLBACK_VECTOR
> >
> > Does this need to be:
> >
> > select X86_HV_CALLBACK_VECTOR if X86
> >
> > I haven't checked whether it gives a warning on arm64 but that symbol
> > doesn't exist.
The symbol is only referenced in code under arch/x86, so there's
no warning when building for arm64. But yes, it would be good
hygiene to add the "if X86".
Michael
> >
> > Anyway, I can fix it up locally.
>
> I can fix it up while I queue these patches.
>
> Wei.
next prev parent reply other threads:[~2021-08-04 16:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 15:52 [PATCH v12 0/5] Enable Linux guests on Hyper-V on ARM64 Michael Kelley
2021-08-04 15:52 ` [PATCH v12 1/5] arm64: hyperv: Add Hyper-V hypercall and register access utilities Michael Kelley
2021-08-04 15:52 ` [PATCH v12 2/5] arm64: hyperv: Add panic handler Michael Kelley
2021-08-04 15:52 ` [PATCH v12 3/5] arm64: hyperv: Initialize hypervisor on boot Michael Kelley
2021-08-04 15:52 ` [PATCH v12 4/5] arm64: efi: Export screen_info Michael Kelley
2021-08-04 15:52 ` [PATCH v12 5/5] Drivers: hv: Enable Hyper-V code to be built on ARM64 Michael Kelley
2021-08-04 16:10 ` Catalin Marinas
2021-08-04 16:40 ` Wei Liu
2021-08-04 16:43 ` Michael Kelley [this message]
2021-08-04 16:25 ` [PATCH v12 0/5] Enable Linux guests on Hyper-V " Catalin Marinas
2021-08-04 16:37 ` Wei Liu
2021-08-04 16:39 ` Michael Kelley
2021-08-04 16:43 ` Catalin Marinas
2021-08-04 16:58 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR21MB15939FD6BE722550ED25FA5CD7F19@MWHPR21MB1593.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=Mark.Rutland@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).