From: Boqun Feng <boqun.feng@gmail.com>
To: Sunil Muthuswamy <sunilmut@microsoft.com>
Cc: "Michael Kelley" <mikelley@microsoft.com>,
"Boqun Feng" <Boqun.Feng@microsoft.com>,
"KY Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
"Dexuan Cui" <decui@microsoft.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"\"Krzysztof Wilczyński\"" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Wei Liu" <wei.liu@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] PCI: hv: Make the code arch neutral
Date: Thu, 16 Sep 2021 09:48:02 +0800 [thread overview]
Message-ID: <YUKiUuwPfuGEFqr+@boqun-archlinux> (raw)
In-Reply-To: <MW4PR21MB2002AE9B673A54D748BD1F2DC0D99@MW4PR21MB2002.namprd21.prod.outlook.com>
On Mon, Sep 13, 2021 at 05:36:46PM +0000, Sunil Muthuswamy wrote:
> This patch makes the Hyper-V vPCI code architectural neutral by
> moving the architectural dependent pieces into arch specific
> code. This allows for the implementation of Hyper-V vPCI for
> other architecture such as ARM64.
>
> There are no functional changes expected from this patch.
>
> Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
This overall looks good to me, I think you may want to base on 5.15-rc1
which has Michael's and my patches on which this patchset depends.
A small nit below:
[...]
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 62dbe98d1fe1..b7213b57b4ec 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -44,8 +44,8 @@
> #include <linux/delay.h>
> #include <linux/semaphore.h>
> #include <linux/irqdomain.h>
> -#include <asm/irqdomain.h>
> -#include <asm/apic.h>
> +//#include <asm/irqdomain.h>
> +//#include <asm/apic.h>
remove the commented out #include too.
Regards,
Boqun
> #include <linux/irq.h>
> #include <linux/msi.h>
> #include <linux/hyperv.h>
[...]
prev parent reply other threads:[~2021-09-16 1:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 17:36 [PATCH 1/2] PCI: hv: Make the code arch neutral Sunil Muthuswamy
2021-09-16 1:48 ` Boqun Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUKiUuwPfuGEFqr+@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=Boqun.Feng@microsoft.com \
--cc=bhelgaas@google.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mikelley@microsoft.com \
--cc=robh@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).