From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B28C6FA82 for ; Fri, 23 Sep 2022 10:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230282AbiIWKcb (ORCPT ); Fri, 23 Sep 2022 06:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231184AbiIWKcF (ORCPT ); Fri, 23 Sep 2022 06:32:05 -0400 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E2A11E940; Fri, 23 Sep 2022 03:31:43 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id cc5so19756090wrb.6; Fri, 23 Sep 2022 03:31:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=A9wlHYFAq0AQmjZo7EO8S4zutuhpaxaPGL/xvuEkjLw=; b=SQD4nUUWYh7NcKGyvqv90wFeI+5RweyAoH8VUQ9lDvchl9JWpkc6W4jjtUvLROKRvo AUIHX2RVuHDAQrLdAbYd+DdRBMwmrRVfpT+lYiXIEghhUzraQr2OBuuguFFCfrakny36 sZMoSzPwMW6RTcDTBwnoOmoap8LKwZcmRuOwFu/bLNcBh9E5bqOq2Mn9bgXPMjKIo0m6 uDhaRkRJp0feYhU94KtZZ85Y562rdwaJRScA2WcxN7+vezT0AsBUP+wsueViGuH+RA0T zPdUjzjAa0YJZ8nOyEZObYgB1BYu8OqtW0EzBo5ySGgWvuMjeS/2XJvPIDlVCfOwS7oC QfCQ== X-Gm-Message-State: ACrzQf0oo2XWoFmc1pHuQAg1oczsUQPi3G+KdgPzP5M1kz/9Wkh2GCVE bcLWw4oTOPVH16OpVcrUKtI= X-Google-Smtp-Source: AMsMyM6kUy00xtx2umIT5gOPwcOwg9rhuDYGgVjP0ZymfYzghCkv5BH2dEwxm6nnoCc9VvAlSyy3Ag== X-Received: by 2002:a5d:6481:0:b0:228:dc1f:4f95 with SMTP id o1-20020a5d6481000000b00228dc1f4f95mr4819035wri.298.1663929101394; Fri, 23 Sep 2022 03:31:41 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c19cf00b003a2f2bb72d5sm2600840wmq.45.2022.09.23.03.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 03:31:40 -0700 (PDT) Date: Fri, 23 Sep 2022 10:31:39 +0000 From: Wei Liu To: "Michael Kelley (LINUX)" Cc: Easwar Hariharan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] hv: Use PCI_VENDOR_ID_MICROSOFT for better discoverability Message-ID: References: <1663625084-2518-1-git-send-email-eahariha@linux.microsoft.com> <1663625084-2518-2-git-send-email-eahariha@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Thu, Sep 22, 2022 at 10:43:24PM +0000, Michael Kelley (LINUX) wrote: > From: Michael Kelley (LINUX) Sent: Thursday, September 22, 2022 3:39 PM > > > > From: Easwar Hariharan Sent: Monday, September > > 19, 2022 3:05 PM > > > > > > pci_ids.h already defines PCI_VENDOR_ID_MICROSOFT, and is included via > > > linux/pci.h. Use the define instead of the magic number. > > > > > > Signed-off-by: Easwar Hariharan > > > --- > > > drivers/hv/vmbus_drv.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > > > index 3c833ea..f2efb74 100644 > > > --- a/drivers/hv/vmbus_drv.c > > > +++ b/drivers/hv/vmbus_drv.c > > > @@ -2052,7 +2052,7 @@ struct hv_device *vmbus_device_create(const guid_t > > *type, > > > child_device_obj->channel = channel; > > > guid_copy(&child_device_obj->dev_type, type); > > > guid_copy(&child_device_obj->dev_instance, instance); > > > - child_device_obj->vendor_id = 0x1414; /* MSFT vendor ID */ > > > + child_device_obj->vendor_id = PCI_VENDOR_ID_MICROSOFT; > > > > > > return child_device_obj; > > > } > > > -- > > > 1.8.3.1 > > > > Reviewed-by: Michael Kelley > > Actually, a nit: The short commit message should start with "Drivers: hv:" or > "Drivers: hv: vmbus:". Check the commit history on vmbus_drv.c and you'll > see the standard usage. I fixed up the commit message and applied it to hyperv-next. Thanks. > > Michael >