From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19677C3A5A0 for ; Mon, 19 Aug 2019 13:28:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E03BC2085A for ; Mon, 19 Aug 2019 13:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727659AbfHSN2A (ORCPT ); Mon, 19 Aug 2019 09:28:00 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:47221 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727614AbfHSN2A (ORCPT ); Mon, 19 Aug 2019 09:28:00 -0400 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hzhhQ-0004Vx-MT; Mon, 19 Aug 2019 15:27:52 +0200 Date: Mon, 19 Aug 2019 15:27:51 +0200 (CEST) From: Thomas Gleixner To: lantianyu1986@gmail.com cc: pbonzini@redhat.com, rkrcmar@redhat.com, corbet@lwn.net, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, sashal@kernel.org, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, michael.h.kelley@microsoft.com, Tianyu Lan , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, vkuznets@redhat.com Subject: Re: [PATCH V3 2/3] KVM/Hyper-V: Add new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH In-Reply-To: <20190819131737.26942-3-Tianyu.Lan@microsoft.com> Message-ID: References: <20190819131737.26942-1-Tianyu.Lan@microsoft.com> <20190819131737.26942-3-Tianyu.Lan@microsoft.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Mon, 19 Aug 2019, lantianyu1986@gmail.com wrote: > From: Tianyu Lan > > This patch adds Same git grep command as before > new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH and let baseball cap? Please do not use weird acronyms. This is text and there is not limitation on characters. > user space to enable direct tlb flush function when only Hyper-V > hypervsior capability is exposed to VM. Sorry, but I'm not understanding this sentence. > This patch also adds Once more > enable_direct_tlbflush callback in the struct kvm_x86_ops and > platforms may use it to implement direct tlb flush support. Please tell in the changelog WHY you are doing things not what. The what is obviously in the patch. So you want to explain what you are trying to achieve and why it is useful. Then you can add a short note about what you are adding, but not at the level of detail which is available from the diff itself. Thanks, tglx