From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F6A9C433DF for ; Wed, 22 Jul 2020 23:42:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75FC12086A for ; Wed, 22 Jul 2020 23:42:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="sUkVovD5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728607AbgGVXmb (ORCPT ); Wed, 22 Jul 2020 19:42:31 -0400 Received: from linux.microsoft.com ([13.77.154.182]:48522 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbgGVXmb (ORCPT ); Wed, 22 Jul 2020 19:42:31 -0400 Received: by linux.microsoft.com (Postfix, from userid 1070) id 3850520B4908; Wed, 22 Jul 2020 16:42:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3850520B4908 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1595461350; bh=8nFQ2Lcsut3ehCNONJCifbSUqk3XtP90FAvfPGV5V8M=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sUkVovD5JtN3wMWJ9+zyQkFggOHc3SD7UuQcLlEiOuw6g827SaoLx597VeqeeDNZQ ZBjooW8odcJ89N/QoqTmJAoLcFN4j5lw8HNR8xtTeCH+cBQc6vQRzYUXsB3JL3QV8Y lmRY29tSV4LDlRjcFc/ltBQA+E/F7ArRkbMhR71c= Received: from localhost (localhost [127.0.0.1]) by linux.microsoft.com (Postfix) with ESMTP id 33D97307032D; Wed, 22 Jul 2020 16:42:30 -0700 (PDT) Date: Wed, 22 Jul 2020 16:42:30 -0700 (PDT) From: Chi Song X-X-Sender: chisong@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net To: Florian Fainelli cc: Jakub Kicinski , Chi Song , Stephen Hemminger , David Miller , Haiyang Zhang , KY Srinivasan , Stephen Hemminger , "wei.liu@kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table In-Reply-To: <78ca93f5-bb3f-96f9-17c5-3c1855b11a40@gmail.com> Message-ID: References: <20200721122127.3ce422f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <78ca93f5-bb3f-96f9-17c5-3c1855b11a40@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Tue, 21 Jul 2020, Florian Fainelli wrote: > On 7/21/20 12:21 PM, Jakub Kicinski wrote: > > On Tue, 21 Jul 2020 04:58:59 +0000 Chi Song wrote: > >> An imbalanced TX indirection table causes netvsc to have low > >> performance. This table is created and managed during runtime. To help > >> better diagnose performance issues caused by imbalanced tables, add > >> device attributes to show the content of TX indirection tables. > >> > >> Signed-off-by: Chi Song > > > > Sorry for waiting until v6 but sysfs feel like a very strange place to > > expose this. Especially under the netdev, not the bus device. > > > > This looks like device specific state, perhaps ethtool -d is a more > > appropriate place? > > Agreed, or a devlink resource maybe? Thank you for comments, I will move it to ethtool.