From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arch@vger.kernel.org
Cc: patches@lists.linux.dev, mikelley@microsoft.com,
kys@microsoft.com, wei.liu@kernel.org, haiyangz@microsoft.com,
decui@microsoft.com, apais@linux.microsoft.com,
Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com,
mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com,
jinankjain@linux.microsoft.com, vkuznets@redhat.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org,
catalin.marinas@arm.com
Subject: Re: [PATCH v2 02/15] mshyperv: Introduce hv_get_hypervisor_version function
Date: Thu, 17 Aug 2023 16:43:49 -0700 [thread overview]
Message-ID: <b3ce3163-aebf-4dd6-b08c-b09a1224b2cb@linux.microsoft.com> (raw)
In-Reply-To: <0d18816a-c46e-ac7e-b98f-ef3dba1c356e@intel.com>
On 8/17/2023 4:14 PM, Dave Hansen wrote:
> On 8/17/23 15:01, Nuno Das Neves wrote:
>> +int hv_get_hypervisor_version(union hv_hypervisor_version_info *info)
>> +{
>> + hv_get_vpreg_128(HV_REGISTER_HYPERVISOR_VERSION,
>> + (struct hv_get_vp_registers_output *)info);
>> +
>> + return 0;
>> +}
> ...
>> +int hv_get_hypervisor_version(union hv_hypervisor_version_info *info)
>> +{
>> + unsigned int hv_max_functions;
>> +
>> + hv_max_functions = cpuid_eax(HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS);
>> + if (hv_max_functions < HYPERV_CPUID_VERSION) {
>> + pr_err("%s: Could not detect Hyper-V version\n",
>> + __func__);
>> + return -ENODEV;
>> + }
>> +
>> + info->eax = cpuid_eax(HYPERV_CPUID_VERSION);
>> + info->ebx = cpuid_ebx(HYPERV_CPUID_VERSION);
>> + info->ecx = cpuid_ecx(HYPERV_CPUID_VERSION);
>> + info->edx = cpuid_edx(HYPERV_CPUID_VERSION);
>> +
>> + return 0;
>> +}
>
> I can't help but notice that the ARM version does *one* call to the
> hardware while the x86 version does CPUID four different times, once to
> get *EACH* register and throwing away the other three registers each
> time. Also recall that CPUID is a big, fat architecturally serializing
> instruction. This isn't a fast path, but CPUID is about as slow as you get.
>
Good point, it is quite wasteful. I just went and checked cpuid.h, and of
course there is a generic cpuid() function that can get all 4 at once.
I will update it to use this in the next version. Thanks!
> Is there any reason you can't just have an x86 version of
> hv_get_vpreg_128() that gets the 128 bits bytes of data that comes back
> in the 4 CPUID registers?
>
> That might even let you share some more code.
Unfortunately, for some reason the hypervisor only lets you get this data via
CPUID on x86_64, and via hypercall - i.e. hv_get_vpreg_128() - on ARM64.
next prev parent reply other threads:[~2023-08-17 23:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 22:01 [PATCH v2 00/15] Introduce /dev/mshv drivers Nuno Das Neves
2023-08-17 22:01 ` [PATCH v2 01/15] hyperv-tlfs: Change shared HV_REGISTER_* defines to HV_MSR_* Nuno Das Neves
2023-08-18 18:45 ` Wei Liu
2023-08-17 22:01 ` [PATCH v2 02/15] mshyperv: Introduce hv_get_hypervisor_version function Nuno Das Neves
2023-08-17 23:14 ` Dave Hansen
2023-08-17 23:43 ` Nuno Das Neves [this message]
2023-08-17 22:01 ` [PATCH v2 03/15] mshyperv: Introduce numa_node_to_proximity_domain_info Nuno Das Neves
2023-08-17 23:22 ` Dave Hansen
2023-08-18 0:17 ` Nuno Das Neves
2023-08-18 0:26 ` Dave Hansen
2023-08-17 22:01 ` [PATCH v2 04/15] asm-generic/mshyperv: Introduce hv_recommend_using_aeoi() Nuno Das Neves
2023-08-17 22:01 ` [PATCH v2 05/15] hyperv: Move hv_connection_id to hyperv-tlfs Nuno Das Neves
2023-08-18 23:22 ` Wei Liu
2023-08-17 22:01 ` [PATCH v2 06/15] hyperv-tlfs: Introduce hv_status_to_string and hv_status_to_errno Nuno Das Neves
2023-08-18 23:23 ` Wei Liu
2023-08-17 22:01 ` [PATCH v2 07/15] Drivers: hv: Move hv_call_deposit_pages and hv_call_create_vp to common code Nuno Das Neves
2023-08-17 22:01 ` [PATCH v2 08/15] Drivers: hv: Introduce per-cpu event ring tail Nuno Das Neves
2023-08-18 23:26 ` Wei Liu
2023-08-17 22:01 ` [PATCH v2 09/15] Drivers: hv: Introduce hv_output_arg_exists in hv_common.c Nuno Das Neves
2023-08-18 23:23 ` Wei Liu
2023-08-17 22:01 ` [PATCH v2 10/15] x86: hyperv: Add mshv_handler irq handler and setup function Nuno Das Neves
2023-08-29 7:47 ` Tianyu Lan
2023-08-17 22:01 ` [PATCH v2 11/15] Drivers: hv: export vmbus_isr, hv_context and hv_post_message Nuno Das Neves
2023-08-17 22:01 ` [PATCH v2 12/15] Documentation: Reserve ioctl number for mshv driver Nuno Das Neves
2023-08-18 23:24 ` Wei Liu
2023-08-17 22:01 ` [PATCH v2 13/15] uapi: hyperv: Add mshv driver headers hvhdk.h, hvhdk_mini.h, hvgdk.h, hvgdk_mini.h Nuno Das Neves
2023-08-17 23:01 ` Wei Liu
2023-08-19 10:26 ` Greg KH
2023-08-25 18:24 ` Nuno Das Neves
2023-10-10 22:49 ` Nuno Das Neves
2023-10-11 6:42 ` Greg KH
2023-10-12 1:56 ` Nuno Das Neves
2023-08-17 22:01 ` [PATCH v2 14/15] asm-generic: hyperv: Use mshv headers conditionally. Add asm-generic/hyperv-defs.h Nuno Das Neves
2023-08-18 23:30 ` Wei Liu
[not found] ` <1692309711-5573-16-git-send-email-nunodasneves@linux.microsoft.com>
2023-08-18 13:08 ` [PATCH v2 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V Saurabh Singh Sengar
2023-08-18 18:59 ` Nuno Das Neves
2023-08-20 5:19 ` Saurabh Singh Sengar
2023-08-22 20:18 ` Nuno Das Neves
2023-08-23 7:40 ` Saurabh Singh Sengar
2023-08-25 18:26 ` Nuno Das Neves
2023-08-21 18:18 ` Saurabh Singh Sengar
2023-08-22 21:00 ` Nuno Das Neves
2023-08-24 18:31 ` Boqun Feng
2023-08-25 18:41 ` Nuno Das Neves
2023-08-25 20:15 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3ce3163-aebf-4dd6-b08c-b09a1224b2cb@linux.microsoft.com \
--to=nunodasneves@linux.microsoft.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=apais@linux.microsoft.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jinankjain@linux.microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=mukeshrathor@microsoft.com \
--cc=patches@lists.linux.dev \
--cc=ssengar@linux.microsoft.com \
--cc=stanislav.kinsburskiy@gmail.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).