From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org,
pbonzini@redhat.com, rkrcmar@redhat.com, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
boris.ostrovsky@oracle.com, jgross@suse.com,
peterz@infradead.org, will@kernel.org,
linux-hyperv@vger.kernel.org, kvm@vger.kernel.org,
mikelley@microsoft.com, kys@microsoft.com,
haiyangz@microsoft.com, sthemmin@microsoft.com,
sashal@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v7 2/5] x86/kvm: Change print code to use pr_*() format
Date: Wed, 23 Oct 2019 09:29:46 +0800 [thread overview]
Message-ID: <c72b01a4-f9a3-cc94-6e9a-3d7d576f232c@oracle.com> (raw)
In-Reply-To: <20191022210120.GQ2343@linux.intel.com>
On 2019/10/23 5:01, Sean Christopherson wrote:
> On Mon, Oct 21, 2019 at 05:11:13PM +0800, Zhenzhong Duan wrote:
>> pr_*() is preferred than printk(KERN_* ...), after change all the print
>> in arch/x86/kernel/kvm.c will have "kvm_guest: xxx" style.
>>
>> No functional change.
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Krcmar <rkrcmar@redhat.com>
>> Cc: Sean Christopherson <sean.j.christopherson@intel.com>
>> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
>> Cc: Wanpeng Li <wanpengli@tencent.com>
>> Cc: Jim Mattson <jmattson@google.com>
>> Cc: Joerg Roedel <joro@8bytes.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Borislav Petkov <bp@alien8.de>
>> Cc: "H. Peter Anvin" <hpa@zytor.com>
>> ---
>> arch/x86/kernel/kvm.c | 30 ++++++++++++++++--------------
>> 1 file changed, 16 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
>> index 3bc6a266..249f14a 100644
>> --- a/arch/x86/kernel/kvm.c
>> +++ b/arch/x86/kernel/kvm.c
>> @@ -7,6 +7,8 @@
>> * Authors: Anthony Liguori <aliguori@us.ibm.com>
>> */
>>
>> +#define pr_fmt(fmt) "kvm_guest: " fmt
> Sort of a silly nit, especially since I suggested kvm_guest...
>
> What about using kvm-guest instead of kvm_guest to be consistent with
> kvm-clock, the other prolific logger in a KVM guest.
>
> E.g.
>
> kvm-clock: cpu 1, msr 551e041, secondary cpu clock
> kvm-guest: setup async PF for cpu 1
> kvm-guest: stealtime: cpu 1, msr 277695f40
> kvm-clock: cpu 2, msr 551e081, secondary cpu clock
> kvm-guest: setup async PF for cpu 2
> kvm-guest: stealtime: cpu 2, msr 277715f40
> kvm-clock: cpu 3, msr 551e0c1, secondary cpu clock
> kvm-guest: setup async PF for cpu 3
> kvm-guest: stealtime: cpu 3, msr 277795f40
> kvm-clock: cpu 4, msr 551e101, secondary cpu clock
>
> instead of
>
> kvm-clock: cpu 1, msr 551e041, secondary cpu clock
> kvm_guest: setup async PF for cpu 1
> kvm_guest: stealtime: cpu 1, msr 277695f40
> kvm-clock: cpu 2, msr 551e081, secondary cpu clock
> kvm_guest: setup async PF for cpu 2
> kvm_guest: stealtime: cpu 2, msr 277715f40
> kvm-clock: cpu 3, msr 551e0c1, secondary cpu clock
> kvm_guest: setup async PF for cpu 3
> kvm_guest: stealtime: cpu 3, msr 277795f40
> kvm-clock: cpu 4, msr 551e101, secondary cpu clock
Good suggestion, will do, thanks for point out.
Zhenzhong
next prev parent reply other threads:[~2019-10-23 1:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 9:11 [PATCH v7 0/5] Add a unified parameter "nopvspin" Zhenzhong Duan
2019-10-21 9:11 ` [PATCH v7 1/5] Revert "KVM: X86: Fix setup the virt_spin_lock_key before static key get initialized" Zhenzhong Duan
2019-10-21 9:11 ` [PATCH v7 2/5] x86/kvm: Change print code to use pr_*() format Zhenzhong Duan
2019-10-22 21:01 ` Sean Christopherson
2019-10-23 1:29 ` Zhenzhong Duan [this message]
2019-10-21 9:11 ` [PATCH v7 3/5] x86/kvm: Add "nopvspin" parameter to disable PV spinlocks Zhenzhong Duan
2019-10-22 11:36 ` Vitaly Kuznetsov
2019-10-22 12:46 ` Zhenzhong Duan
2019-10-22 13:11 ` Vitaly Kuznetsov
2019-10-22 21:03 ` Sean Christopherson
2019-10-23 1:36 ` Zhenzhong Duan
2019-10-21 9:11 ` [PATCH v7 4/5] xen: Mark "xen_nopvspin" parameter obsolete Zhenzhong Duan
2019-10-21 9:11 ` [PATCH v7 5/5] x86/hyperv: Mark "hv_nopvspin" " Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c72b01a4-f9a3-cc94-6e9a-3d7d576f232c@oracle.com \
--to=zhenzhong.duan@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=sashal@kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).