From: Markus Elfring <Markus.Elfring@web.de>
To: Haiyang Zhang <haiyangz@microsoft.com>,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Olaf Hering <olaf@aepfle.de>, Sasha Levin <sashal@kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH net-next, 2/4] hv_netvsc: Fix error handling in netvsc_attach()
Date: Fri, 1 Nov 2019 21:42:41 +0100 [thread overview]
Message-ID: <cdf7b308-940a-ff9c-07ae-f42b94687e24@web.de> (raw)
In-Reply-To: <1572296801-4789-3-git-send-email-haiyangz@microsoft.com>
> If rndis_filter_open() fails, we need to remove the rndis device created
> in earlier steps, before returning an error code. Otherwise, the retry of
> netvsc_attach() from its callers will fail and hang.
How do you think about to choose a more “imperative mood” for your
change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=0dbe6cb8f7e05bc9611602ef45980a6c57b245a3#n151
…
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -982,7 +982,7 @@ static int netvsc_attach(struct net_device *ndev,
> if (netif_running(ndev)) {
> ret = rndis_filter_open(nvdev);
> if (ret)
> - return ret;
> + goto err;
>
> rdev = nvdev->extension;
> if (!rdev->link_state)
…
I would prefer to specify the completed exception handling
(addition of two function calls) by a compound statement in
the shown if branch directly.
If you would insist to use a goto statement, I find an other label
more appropriate according to the Linux coding style.
Regards,
Markus
next prev parent reply other threads:[~2019-11-01 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 21:06 [PATCH net-next, 0/4] hv_netvsc: Add XDP support and some error handling fixes Haiyang Zhang
2019-10-28 21:07 ` [PATCH net-next, 1/4] hv_netvsc: Fix error handling in netvsc_set_features() Haiyang Zhang
2019-10-28 21:07 ` [PATCH net-next, 2/4] hv_netvsc: Fix error handling in netvsc_attach() Haiyang Zhang
2019-11-01 20:42 ` Markus Elfring [this message]
2019-11-04 15:08 ` Haiyang Zhang
2019-10-28 21:07 ` [PATCH net-next, 3/4] hv_netvsc: Add XDP support Haiyang Zhang
2019-10-28 21:33 ` Jakub Kicinski
2019-10-29 19:17 ` Haiyang Zhang
2019-10-29 19:53 ` Jakub Kicinski
2019-10-29 20:01 ` Haiyang Zhang
2019-10-29 21:59 ` Stephen Hemminger
2019-10-29 22:08 ` Haiyang Zhang
2019-10-28 21:07 ` [PATCH net-next, 4/4] hv_netvsc: Update document for " Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdf7b308-940a-ff9c-07ae-f42b94687e24@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).