From: Sergey Shtylyov <s.shtylyov@omprussia.ru>
To: <linux-i2c@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH 2/2] i2c: synquacer: fix deferred probing
Date: Sat, 17 Apr 2021 23:59:25 +0300 [thread overview]
Message-ID: <0f65c68a-8457-8bae-086a-e473130cf4bb@omprussia.ru> (raw)
In-Reply-To: <dfa042b7-8b80-ee2b-451b-7cedaeadfd02@omprussia.ru>
The driver overrides the error codes returned by platform_get_irq() to
-ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream...
Fixes: 0d676a6c4390 ("i2c: add support for Socionext SynQuacer I2C controller")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
drivers/i2c/busses/i2c-synquacer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/i2c/busses/i2c-synquacer.c
===================================================================
--- linux.orig/drivers/i2c/busses/i2c-synquacer.c
+++ linux/drivers/i2c/busses/i2c-synquacer.c
@@ -578,7 +578,7 @@ static int synquacer_i2c_probe(struct pl
i2c->irq = platform_get_irq(pdev, 0);
if (i2c->irq < 0)
- return -ENODEV;
+ return i2c->irq;
ret = devm_request_irq(&pdev->dev, i2c->irq, synquacer_i2c_isr,
0, dev_name(&pdev->dev), i2c);
next prev parent reply other threads:[~2021-04-17 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 20:57 [PATCH0/2] Fix deferred probing in the I2C bus drivers Sergey Shtylyov
2021-04-17 20:58 ` [PATCH 1/2] i2c: iop3xx: fix deferred probing Sergey Shtylyov
2021-04-17 20:59 ` Sergey Shtylyov [this message]
2021-05-28 20:57 ` [PATCH0/2] Fix deferred probing in the I2C bus drivers Sergey Shtylyov
2021-05-30 15:53 ` Sergey Shtylyov
2021-05-30 16:01 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f65c68a-8457-8bae-086a-e473130cf4bb@omprussia.ru \
--to=s.shtylyov@omprussia.ru \
--cc=ardb@kernel.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).