From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63F8C41604 for ; Tue, 6 Oct 2020 08:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E96820789 for ; Tue, 6 Oct 2020 08:02:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fpond.eu header.i=@fpond.eu header.b="NmCEaVzX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725912AbgJFIC1 (ORCPT ); Tue, 6 Oct 2020 04:02:27 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.23]:18187 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725891AbgJFIC1 (ORCPT ); Tue, 6 Oct 2020 04:02:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1601971346; s=strato-dkim-0002; d=fpond.eu; h=Subject:References:In-Reply-To:Message-ID:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=MHJ/AaYzurHr9F8plviGVBELLffgMer4Xh9xNz4R5VE=; b=NmCEaVzX3xGiXkjV0hmlvnbKoE+/OpkVlYFGYVhe/SndOnUa0LvY0JqjqSQd686iSn cSCWUQMlvKwo4zyru0C/M13/7UPnOUPNRiVmZT4zinE48SvTPzGnsSIkvknfcCHgOjy3 DrO/u7nQBjpKmCQcTt7pz8Jifi5rZLzS7FByT0roWFc8oMUwJ2EyeK9j1QlxHBA+AU+D F0GZ/H1GMzj0D1NQZE4DXRNhDIHf9zC4yNvhDEyQ6elpOueQ4p25M2u9bREw0SMW0MVH EsLB9Q9hppriCaQuadXFqUjafBdrYiT9cqd/JFsdjgf4PEK3qce6CUxuFNr/nU15SWyg YQIw== X-RZG-AUTH: ":OWANVUa4dPFUgKR/3dpvnYP0Np73amq+g13rqGzvv3qxio1R8fCt/7B6PNk=" X-RZG-CLASS-ID: mo00 Received: from oxapp04-01.back.ox.d0m.de by smtp-ox.front (RZmta 47.2.1 AUTH) with ESMTPSA id a056fbw967xL9ql (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Tue, 6 Oct 2020 09:59:21 +0200 (CEST) Date: Tue, 6 Oct 2020 09:59:21 +0200 (CEST) From: Ulrich Hecht To: Wolfram Sang , Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, geert@linux-m68k.org, linux-i2c@vger.kernel.org, Geert Uytterhoeven Message-ID: <1440786741.680679.1601971161395@webmail.strato.com> In-Reply-To: <20201002154423.GA16758@ninjato> References: <20200928155950.1185-1-uli+renesas@fpond.eu> <20201002154423.GA16758@ninjato> Subject: Re: [PATCH v4] i2c: sh_mobile: implement atomic transfers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.3-Rev22 X-Originating-Client: open-xchange-appsuite Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org > On 10/02/2020 5:44 PM Wolfram Sang wrote: > > + if (sr & (ICSR_AL | ICSR_TACK | > > + ICSR_WAIT | ICSR_DTE)) { > > + sh_mobile_i2c_isr(0, pd); > > + udelay(150); > > + } else { > > And where does the value 150us come from? Anything more than (IIRC) 50us or so works, but I tried to be conservative. Not waiting at all does not work, though. It is not quite clear to me why, because the bits tested here are the conditions for an interrupt to be triggered. CU Uli